simple-scan-team team mailing list archive

[Robert Ancell <robert.ancell@xxxxxxxxxxxxx>]

Thanks for fixing the .ui file indentation - it's much easier to read now.

You haven't done the replaces in src/ui.vala - for example on line 1670 there is a reference to "text_toolbutton_menuitem" but you've renamed it to "text_menuitem".

Please move the app menu logic back - there's no problem calling has_app_menu () more than once and it makes the try clause contain more code than necessary. We are only checking for UI load failures at this point.

btw You should change your review to "Approve" unless you disapprove of your own code!
-- 
https://code.launchpad.net/~gotwig/simple-scan/headerbars/+merge/220878
Your team Simple Scan Development Team is subscribed to branch lp:simple-scan.