slub.team team mailing list archive

[Ralf Claussnitzer <ralf.claussnitzer@xxxxxxxxxxxxxxx>]

Review: Disapprove

This merge includes too many changes in a single commit addressing too many issues at once. Please consider providing separate merge requests (with smaller commits) backed up by a concrete bug report or blueprint.

Your contribution is appreciated. Please let us know how we can support you with separating the submitted changes.

Looking at the changelog you provided, I can spot the following bug fixes and refactorings:

>>>>
Refactoring (best defined in individual blueprints):
- File system functionality has been moved from “Helper” and “Prozess” into a new Class “FilesystemHelper”.
- Code has been refactored, checking for existence of a directory has been centralised.
- Scripting functionality has been moved from “Helper” into a new Class “ShellScript”.
- The error level return value can now be accessed independend of output to stderr.
- Code has been refactored, the results parsing has been centralised, stub methods isEmptyCommand() and closeProcessStreams() have been re-integrated.

Bug Fix (yet without reports):
- A locking issue with the file renaming functionality, especially under Windows, has been fixed.
- White spaces in path names are now correctly passed to the ProcessBuilder.
<<<<<


-- 
https://code.launchpad.net/~zeutschel/goobi-production/refactoring-filesystem-and-shellscript-functions/+merge/103264
Your team Saxon State Library Team is subscribed to branch lp:goobi-production.