slub.team team mailing list archive

[Matthias Ronge <matthias.ronge@xxxxxxxxxxxx>]

Functionality in FilesystemHelper and ShellScript is largely written new and is commented there in Javadoc format. The other classes were adapted to use the new methods, and the henceforward dead code was removed. I think, if you inspect the two new classes first you will easily discover the design idea of the change. I don’t see a way to split up this change into smaller pieces, except perhaps for the locking issue.

You can comfortably browse the changes under
http://bazaar.launchpad.net/~zeutschel/goobi-production/refactoring-filesystem-and-shellscript-functions/revision/58?start_revid=58

Btw, I would like to discourage from reporting bugs for code smells, since tidying up the code should be a continuing process and there is a certain danger of flooding launchpad with reports kind of “there is contrived complexity in class X”, “an uncommunicative variable name was used in class Z”, etc.
-- 
https://code.launchpad.net/~zeutschel/goobi-production/refactoring-filesystem-and-shellscript-functions/+merge/103264
Your team Saxon State Library Team is subscribed to branch lp:goobi-production.