slub.team team mailing list archive

[Ralf Claussnitzer <ralf.claussnitzer@xxxxxxxxxxxxxxx>]

Review: Needs Fixing

Confirmed. Having "/bin/bash foo.sh" is not a correct command anymore.

An appropriate "File given is not executable" exception should be thrown in this case.
I also strongly suggest to add JUnit tests for the ShellScript class.

However, this is a major behavioral change (in a positive way). We will have to state this in the release notes explicitly.
-- 
https://code.launchpad.net/~zeutschel/goobi-production/refactoring-filesystem-and-shellscript-functions/+merge/105464
Your team Saxon State Library Team is subscribed to branch lp:goobi-production.