slub.team team mailing list archive

[Ralf Claussnitzer <ralf.claussnitzer@xxxxxxxxxxxxxxx>]

Review: Needs Fixing

Looks like good and working code. But there are unrelated changes again. Here are my issues:

1- Please remove /ws and all "webservice" query logic, because this is completely unrelated to message queuing and a mere convenience feature. This clearly belongs elsewhere. We already started a Jersey based REST API that fits for this kind of web based queries. Your query code should be ported to this API implementation. We can do this in a separate branch if you agree. 

2- The documentation is good and comprehensive and thus should not be buried within the code. I think the project root level "/doc" is a good place for those files.

3- Message Queuing with ActiveMQ is not considered a web service, is it? I suggest to reflect that in the package structure and rename org.goobi.webservice to org.goobi.mq

4- The lack of automated testing is an issue, but no show stopper yet.

I've already made some of the above mentioned changes in a separate branch. Maybe you want to pull from there:
lp:~slub.team/goobi-production/mq-interface-to-create-and-finalise-processes
-- 
https://code.launchpad.net/~zeutschel/goobi-production/web-service-interface-to-create-processes/+merge/116688
Your team Saxon State Library Team is subscribed to branch lp:goobi-production.