slub.team team mailing list archive

[Ralf Claussnitzer <ralf.claussnitzer@xxxxxxxxxxxxxxx>]

Review: Disapprove

Major:
(1) Merging FileUtils and removing de.unigoettingen.sub.commons.util is alright, but patching third party library files is generally discouraged. There must be a better way.

Minor:
(2) What's the rationale for moving source code from versioned source tree to unversioned library jar?

(3) The branch is based on yet un-merged branch by lp:henning-gerhardt (commit 88) but should be based on mainline branch.
-- 
https://code.launchpad.net/~zeutschel/goobi-production/bug-1034020/+merge/118896
Your team Saxon State Library Team is subscribed to branch lp:goobi-production.