slub.team team mailing list archive

[Ralf Claussnitzer <ralf.claussnitzer@xxxxxxxxxxxxxxx>]

Ralf Claussnitzer has proposed merging lp:~slub.team/goobi-production/bug-1020941 into lp:goobi-production.

Requested reviews:
  Matthias Ronge (matthias-ronge)
  Henning Gerhardt (henning-gerhardt)
Related bugs:
  Bug #1020941 in Goobi.Production: "save password alert in firefox"
  https://bugs.launchpad.net/goobi-production/+bug/1020941

For more details, see:
https://code.launchpad.net/~slub.team/goobi-production/bug-1020941/+merge/130669

Adds an additional password field for confirmation, so that the browser does not handle the form as an login form anymore. However, due to Tomahawk restrictions the validation message cannot be localized (see known issues: http://myfaces.apache.org/sandbox/tagdoc/s_validateCompareTo.html). For proper localization, a custom validation tag must be defined.
-- 
https://code.launchpad.net/~slub.team/goobi-production/bug-1020941/+merge/130669
Your team Saxon State Library Team is subscribed to branch lp:goobi-production.

=== modified file 'config/messages_de.properties'
--- config/messages_de.properties	2012-09-19 12:32:15 +0000
+++ config/messages_de.properties	2012-10-20 13:07:24 +0000
@@ -527,6 +527,7 @@
 passwortAendern=Passwort \u00E4ndern
 passwortGeaendert=Das Passwort wurde erfolgreich ge\u00E4ndert.
 passwortUngueltig=Passwort ung\u00FCltig
+passwortWiederholen=Passwort (wiederholen)
 path=Pfad
 personBearbeiten=Person bearbeiten
 personen=Personen

=== modified file 'config/messages_en.properties'
--- config/messages_en.properties	2012-09-19 12:32:15 +0000
+++ config/messages_en.properties	2012-10-20 13:07:24 +0000
@@ -527,6 +527,7 @@
 passwortAendern=Change password
 passwortGeaendert=The password has been changed.
 passwortUngueltig=Incorrect password
+passwortWiederholen=Password (repeat)
 path=Path
 personBearbeiten=Edit person
 personen=Persons

=== modified file 'newpages/BenutzerBearbeiten.jsp'
--- newpages/BenutzerBearbeiten.jsp	2012-08-07 09:54:37 +0000
+++ newpages/BenutzerBearbeiten.jsp	2012-10-20 13:07:24 +0000
@@ -144,15 +144,24 @@
 												</h:panelGroup>
 
 												<%-- passwort --%>
-												<h:outputLabel for="passwort" value="#{msgs.passwort}" />
+												<h:outputLabel for="password" value="#{msgs.passwort}" />
 												<h:panelGroup>
-													<h:inputSecret redisplay="true" id="passwort"
+													<h:inputSecret redisplay="true" id="password"
 														style="width: 300px;margin-right:15px"
 														value="#{BenutzerverwaltungForm.myClass.passwortCrypt}"
 														required="true" />
-													<x:message for="passwort" style="color: red"
+													<x:message for="password" style="color: red"
 														replaceIdWithLabel="true" />
 												</h:panelGroup>
+												<h:outputLabel for="passwordConfirm" value="#{msgs.passwortWiederholen}" />
+												<h:panelGroup>
+													<h:inputSecret redisplay="true" id="passwordConfirm"
+														value="#{BenutzerverwaltungForm.myClass.passwortCrypt}"
+														style="width: 300px;margin-right:15px" required="true">
+														<x:validateEqual for="password" message="Passwords do not match."/>
+													</h:inputSecret>
+													<x:message for="passwordConfirm" style="color: red" />
+												</h:panelGroup>
 
 												<%-- LdapGruppe --%>
 												<h:outputLabel