structbiol team mailing list archive

[Tim Fenn <fenn@xxxxxxxxxxxx>]

On Tue, 22 Sep 2009 17:06:29 +0200
Morten Kjeldgaard <mok@xxxxxxxxxxxxx> wrote:

> 
> OK, so this is the first mail using our mailing list!
> 

w00t!

> > make DPS=${PWD} IND=${PWD}/index UTIL=${PWD}/src/dps/util \
> > JPG=${PWD}/jpg AR_FLAG S=vru F77=gfortran FC=gfortran
> > FLINK=gfortran \ MOSLIBS="-lgpp4f -lgpp4 -lncurses - ldl -lpthread
> > -lm"
> 
> That works for me. However, it seems mosflm comes bundled with cbflib
> and libjpg, both of which are packaged for Debian. As we speak, I am
> working to doctor the makefiles (and a few source files) so they use
> the system versions instead.
> 

See the attached patch.

> 
> I understood from the earlier discussion that Harry has equipped
> mosflm with a free license, but there is no mention of it anywhere
> that I can find.
> 

I emailed harry about this - his response:

> Broadly speaking it's the same as the CCP4 license, which I think is  
> GPL2.

I emailed him to clarify this on the website and include something with
the distribution and/or the source.

> 
> Also there is the question of copyright. Mosflm has an author list a
> mile long. Many, many people have had their hands in the software,
> although Andrew Leslie and Harry Powell have been the maintainers and
> developers for the last many years. However, Mosflm is based on the
> MOSCO suite, which was developed by Wonacott and Nyborg. It would be
> useful and interesting, also from a historical perspective, to work
> out the complete list of copyright holders.
> 

I think this is definitely something for upstream - Harry is certainly
the best to do this, I don't know enough about the code and who was
involved to even begin.

-Tim

-- 
---------------------------------------------------------

        Tim Fenn
        fenn@xxxxxxxxxxxx
        Stanford University, School of Medicine
        James H. Clark Center
        318 Campus Drive, Room E300
        Stanford, CA  94305-5432
        Phone:  (650) 736-1714
        FAX:  (650) 736-1961

---------------------------------------------------------

--- Makefile_orig	2009-09-17 01:52:25.000000000 -0700
+++ Makefile	2009-09-17 01:53:20.000000000 -0700
@@ -22,7 +22,7 @@
 CBFLIBS = cbf/lib/libcbf.a
 JPGLIBS = jpg/libjpeg.a
 
-all:	$(DPSLIBS) $(CBFLIBS) $(JPGLIBS)
+all:	$(DPSLIBS)
 	cd mosflm ; make
 
 ##########################################################################
--- mosflm/Makefile_orig	2009-09-17 01:53:28.000000000 -0700
+++ mosflm/Makefile	2009-09-17 01:54:30.000000000 -0700
@@ -10,7 +10,8 @@
 	mosflm_jpeg.o matzerr.o hklmanage.o torefix.o \
 	bravais_fortran.o cbfwrap.o pilatus_c.o
 
-LOCALLIBS   = ${DPSLIB}/DPSLIB.a ../cbf/lib/libcbf.a ../jpg/libjpeg.a
+# LOCALLIBS   = ${DPSLIB}/DPSLIB.a ../cbf/lib/libcbf.a ../jpg/libjpeg.a
+LOCALLIBS   = ${DPSLIB}/DPSLIB.a -lcbf -ljpeg
 
 .SUFFIXES:	.o .c