sts-sponsors team mailing list archive

[Eric Desrochers <eric.desrochers@xxxxxxxxxxxxx>]

[FTBFS - s390x]

* Pending SRU (xenial)
libguestfs s390x: Failed to build
https://launchpad.net/ubuntu/+source/libguestfs/1:1.32.2-4ubuntu2.1/+build/16379018

* Build log
...
checking for qemu-system-s390x... no
configure: error: qemu must be installed
...

* git-ubuntu (libguestfs) 
commit 3928bd5f1458d199cd93e415c9a8081d28048500)

* debdiff

The following should help the build for that particular FTBFS situation 
(if no other build problem found after)

diff -Nru libguestfs-1.32.2/debian/changelog libguestfs-1.32.2/debian/changelog
--- libguestfs-1.32.2/debian/changelog	2019-02-07 13:17:26.000000000 +0000
+++ libguestfs-1.32.2/debian/changelog	2019-02-15 14:25:19.000000000 +0000
@@ -1,3 +1,11 @@
+libguestfs (1:1.32.2-4ubuntu2.2) xenial; urgency=medium
+
+  * Fix FTBFS on s390x arch.
+    - debian/control:
+      + Use qemu-system-s390x on s390x arch.
+
+ -- Eric Desrochers <slashd@xxxxxxxxxx>  Fri, 15 Feb 2019 14:25:19 +0000
+
 libguestfs (1:1.32.2-4ubuntu2.1) xenial; urgency=medium
 
   * d/p/0006-appliance-touch-etc-fstab-when-enabling-the-network.patch:
diff -Nru libguestfs-1.32.2/debian/control libguestfs-1.32.2/debian/control
--- libguestfs-1.32.2/debian/control	2016-03-13 16:04:12.000000000 +0000
+++ libguestfs-1.32.2/debian/control	2019-02-15 14:24:56.000000000 +0000
@@ -18,7 +18,7 @@
   gperf, libxml2-utils,
   qemu-system-arm [armel armhf arm64],
   qemu-system-mips [mips mipsel mips64 mips64el],
-  qemu-system-misc [s390x],
+  qemu-system-s390x [s390x],
   qemu-system-ppc [powerpc ppc64 ppc64el],
   qemu-system-aarch64 [arm64],
   qemu-system-sparc [sparc],
@@ -154,7 +154,7 @@
   supermin (>= 5),
   qemu-system-arm [armel armhf arm64],
   qemu-system-mips [mips mipsel mips64 mips64el],
-  qemu-system-misc [s390x],
+  qemu-system-s390x [s390x],
   qemu-system-aarch64 [arm64],
   qemu-system-ppc [powerpc pc64 ppc64el],
   qemu-system-sparc [sparc],

-- 
You received this bug notification because you are a member of STS
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1814939

Title:
  [FTBFS] libguestfs fails to build on Xenial - dh_install --fail-
  missing

Status in libguestfs package in Ubuntu:
  Fix Released
Status in libguestfs source package in Xenial:
  Fix Committed

Bug description:
  [Impact]

  Ubuntu Version :
  $ lsb_release -rd
  Description:	Ubuntu 16.04.5 LTS
  Release:	16.04

  libguestfs version : 1:1.32.2-4ubuntu2

  When trying to build libguestfs on Ubuntu 16.04 - Xenial, it fails at
  :

  dh_install -X.la -X.so.owner -Xbindtests -X/usr/lib/go/ -Xpackages.orig \
      --fail-missing
  dh_install: usr/lib/go-1.6/pkg/linux_amd64/libguestfs.org/guestfs/guestfs.a exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs_040_create_multiple_test.go exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs_100_launch_test.go exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs_070_optargs_test.go exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs_060_explicit_close_test.go exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs_010_load_test.go exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs_900_rstringlist_test.go exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs.go exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs_030_create_flags_test.go exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs_020_create_test.go exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs_050_handle_properties_test.go exists in debian/tmp but is not installed to anywhere
  dh_install: missing files, aborting
  debian/rules:118: recipe for target 'override_dh_install' failed

  This happens because the dh_install excludes the /usr/lib/go files (-X/usr/lib/go)
  but does not exclude the /usr/lib/go- for the specific version of go.

  The fix replaces the command : 
  dh_install -X.la -X.so.owner -Xbindtests -X/usr/lib/go/ -Xpackages.orig \
      --fail-missing
  with :
  dh_install -X.la -X.so.owner -Xbindtests -X/usr/lib/go/ -X/usr/lib/go- -Xpackages.orig \
      --fail-missing

  [Test Case]

  On a Xenial machine :

  1) $ pull-lp-source libguestfs xenial

  2) $ cd libguestfs-1.32.2/

  3) $ debuild
  dpkg-buildpackage -rfakeroot -D -us -uc
  dpkg-buildpackage: source package libguestfs
  dpkg-buildpackage: source version 1:1.32.2-4ubuntu2
  dpkg-buildpackage: source distribution xenial
  ....
  dh_install -X.la -X.so.owner -Xbindtests -X/usr/lib/go/ -Xpackages.orig \
      --fail-missing
  dh_install: usr/lib/go-1.6/pkg/linux_amd64/libguestfs.org/guestfs/guestfs.a exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs_040_create_multiple_test.go exists in debian/tmp but is not installed to anywhere
  dh_install: usr/lib/go-1.6/src/pkg/libguestfs.org/guestfs/guestfs_100_launch_test.go exists in debian/tmp but is not installed to anywhere
  ...
  debian/rules:118: recipe for target 'override_dh_install' failed

  [Regression Potential]

  * The fix might cause problems when building libguestfs.

  * autopkgtest fails with :

  autopkgtest [14:49:52]: test command1: /usr/bin/dh_golang_autopkgtest
  autopkgtest [14:49:52]: test command1: [-----------------------
  bash: /usr/bin/dh_golang_autopkgtest: No such file or directory
  autopkgtest [14:49:53]: test command1: -----------------------]
  autopkgtest [14:49:53]: test command1:  - - - - - - - - - - results - - - - - - - - - -
  command1             FAIL non-zero exit status 1
  autopkgtest [14:49:54]: @@@@@@@@@@@@@@@@@@@@ summary
  command1             FAIL non-zero exit status 1

  However this is due to the golang test which are excluded from the package.
  The same behaviour is observed when running autopakgtest  for libguestfs on Bionic.

  $ autopkgtest -U libguestfs_1.36.13-1ubuntu3.2.dsc -- lxd ubuntu:bionic
  ...
  autopkgtest [17:55:37]: test command1: /usr/bin/dh_golang_autopkgtest
  autopkgtest [17:55:37]: test command1: [-----------------------
  [error] Can't find import paths.
  autopkgtest [17:55:41]: test command1: -----------------------]
  autopkgtest [17:55:42]: test command1:  - - - - - - - - - - results - - - - - - - - - -
  command1             FAIL non-zero exit status 2
  autopkgtest [17:55:43]: @@@@@@@@@@@@@@@@@@@@ summary
  command1             FAIL non-zero exit status 2

  [Other Info]

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/libguestfs/+bug/1814939/+subscriptions