← Back to team overview

sts-sponsors team mailing list archive

[Bug 1800566] [NEW] Make the reset_devices parameter default for kdump kernels

 

You have been subscribed to a public bug by Eric Desrochers (slashd):

[Impact]
Crash kernels do not advise some subsystems to perform a reset by default.

[Description]
Kernel has the "reset_devices" parameter that drivers can opt-in, and perform special activity in case this parameter is parsed from command-line. For example, in kdump kernels it hints the drivers that they (maybe) are booting from a non-healthy condition and needs to issue some reset to the adapter. Users currently (kernel v4.19) are: hpsa, ipr, megaraid_sas, mpt3sas, smartpqi, xenbus.

This should be enabled by default in the kdump config file to be added
in the kdump kernel command-line for all versions.

[Test Case]
1) Deploy a Disco VM e.g. with uvt-kvm
2) Install the kdump-tools package
3) Run `kdump-config test`and check for the 'reset_devices' parameter:

$ kdump-config test
[...]
kexec command to be used:
  /sbin/kexec -p --command-line="BOOT_IMAGE=/boot/vmlinuz-4.15.0-45-generic root=LABEL=cloudimg-rootfs ro console=tty1 console=ttyS0 nr_cpus=1 systemd.unit=kdump-tools.service irqpoll nousb ata_piix.prefer_ms_hyperv=0" /var/lib/kdump/vmlinuz

[Regression Potential]
The regression potential is very low, since it doesn't need any changes in makedumpfile code and we're only adding a parameter on the crashkernel cmdline.
The fix will be tested with autopkgtests and normal kdump use-case scenarios.

** Affects: makedumpfile (Ubuntu)
     Importance: High
     Assignee: Heitor R. Alves de Siqueira (halves)
         Status: Confirmed

** Affects: makedumpfile (Ubuntu Trusty)
     Importance: High
     Assignee: Heitor R. Alves de Siqueira (halves)
         Status: Confirmed

** Affects: makedumpfile (Ubuntu Xenial)
     Importance: High
     Assignee: Heitor R. Alves de Siqueira (halves)
         Status: Confirmed

** Affects: makedumpfile (Ubuntu Bionic)
     Importance: High
     Assignee: Heitor R. Alves de Siqueira (halves)
         Status: Confirmed

** Affects: makedumpfile (Ubuntu Cosmic)
     Importance: High
     Assignee: Heitor R. Alves de Siqueira (halves)
         Status: Confirmed

** Affects: makedumpfile (Ubuntu Disco)
     Importance: High
     Assignee: Heitor R. Alves de Siqueira (halves)
         Status: Confirmed


** Tags: sts
-- 
Make the reset_devices parameter default for kdump kernels
https://bugs.launchpad.net/bugs/1800566
You received this bug notification because you are a member of STS Sponsors, which is subscribed to the bug report.