sts-sponsors team mailing list archive

[Launchpad Bug Tracker <1747765@xxxxxxxxxxxxxxxxxx>]

You have been subscribed to a public bug by Dariusz Gadomski (dgadomski):

[Impact]

 The documentation allows the following types of arguments for the PreserveJobHistory parameter:
PreserveJobHistory Yes
PreserveJobHistory No
PreserveJobHistory seconds
            
The value in seconds is treated in the same as 'No' resulting in immediate removing of jobs from history, while it is supposed to save it for <seconds>.

[Test Case]

 * Set PreserveJobHistory to 300.
 * Schedule a job for printing.
 * Check the error_log.

Expected result:
Job is save for at least 300 seconds.

Actual results:
Job is immediately removed from history.

[Regression Potential]

 * With the fix the jobs will be saved longer than before, so in tight
conditions (low disk space) and heavy workload it may affect memory/disk
space consumption and lead to running out of free space in worst case.

[Other Info]
 
 * Original bug description:

1) Ubuntu Release
Description:	Ubuntu 16.04.3 LTS
Release:	16.04

2) Version of the package
cups:
  Installed: 2.1.3-4ubuntu0.3
  Candidate: 2.1.3-4ubuntu0.3
  Version table:
 *** 2.1.3-4ubuntu0.3 500
        500 http://us.archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages

3) What I expected to happen:
from man cupsd.conf

      PreserveJobFiles Yes

       PreserveJobFiles No

       PreserveJobFiles seconds
            Specifies  whether  job files (documents) are preserved after a job is printed.  If a numeric value is specified, job files are preserved
            for the indicated number of seconds after printing.  The default is "86400" (preserve 1 day).

       PreserveJobHistory Yes

       PreserveJobHistory No

       PreserveJobHistory seconds
            Specifies whether the job history is preserved after a job is printed.  If a numeric value is specified, the job history is preserved for
            the  indicated number of seconds after printing.  If "Yes", the job history is preserved until the MaxJobs limit is reached.  The default
            is "Yes".

4) What happens instead....

If I put the following directives in cupsd.conf the job files and
history are deleted immediately.

PreserveJobFiles 604800
PreserveJobHistory 604800

Debug log showing history being purged:
d [06/Feb/2018:15:11:59 -0600] cupsdCheckJobs: 0 active jobs, sleeping=0, ac-power=-1, reload=0, curtime=1517951519
d [06/Feb/2018:15:11:59 -0600] cupsdCleanJobs: MaxJobs=100, JobHistory=604800, JobFiles=604800
D [06/Feb/2018:15:11:59 -0600] [Job 106] Removing from history.
D [06/Feb/2018:15:11:59 -0600] [Job 106] Unloading...

** Affects: cups (Ubuntu)
     Importance: Medium
         Status: Fix Released

** Affects: cups (Ubuntu Xenial)
     Importance: Undecided
         Status: New

** Affects: cups (Ubuntu Bionic)
     Importance: Undecided
         Status: New

** Affects: cups (Ubuntu Disco)
     Importance: Undecided
         Status: New

-- 
PreserveJobHistory and PreserveJobLog do not respect numeric input as outlined in the docs
https://bugs.launchpad.net/bugs/1747765
You received this bug notification because you are a member of STS Sponsors, which is subscribed to the bug report.