sts-sponsors team mailing list archive

[Dave Chiluk <1838555@xxxxxxxxxxxxxxxxxx>]

@slashd ,

Reading through the patch, it's exactly as @mruffell says it is.  It's
sequestered into a code path that only exists for micron drives.  A code
path which previously did not exist.  This satisfies the intro, and the
first three bullet points of Other_safe_cases.  This patch is upstream
and AFAICT from git log and comparing of the enablement patch and the
file on master of the public project micron-nvme.c has not changed in
any consequential way.

IMHO. there should be no issue with pushing this in as an SRU into
bionic, and does significantly improve the user experience for those
with Micron drives.  This simultaneously has little to no impact on
other users.

-- 
You received this bug notification because you are a member of STS
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1838555

Title:
  nvme-cli 1.5 in Bionic does not support Micron NVME drives

Status in nvme-cli package in Ubuntu:
  Fix Released
Status in nvme-cli source package in Bionic:
  In Progress

Bug description:
  [Impact]

  This was discovered at a customer site and affects all of their Bionic
  installs that have Micron NVMe drives.

  The version of nvme-cli present in Ubuntu 18.04 Bionic Beaver (1.5-1)
  does not include support to manage updating the firmware on Micron
  NVMe drives. The missing support also means that the customer cannot
  format their block size to 4k, as needed by Ceph.

  Version 1.6-1 and later versions do include this support, and can be
  used by rebuilding the package from upstream source as a static
  binary. This is not ideal, but a workaround.

  [Test Case]

  Install nvme-cli from Bionic, and attempt to update firmware for any
  Micron NVMe drive, using a command similar to the below. It will fail,
  as the drive is not supported.

  $ nvme micron select-download /dev/<nvme_device>n1 --fw
  ./Micron_9200_FW-101008S0.tar --select=ALL

  With the upstream commit patched into place, we can verify the
  subcommands function with:

  $ nvme micron

  This will display the help screen and a list of supported commands.

  $ nvme micron select-download

  This will show the help page for firmware updating, and required
  arguments. Running again with the arguments from the first example
  will update the firmware on the drives successfully.

  You can find a test package for Bionic here:

  https://launchpad.net/~mruffell/+archive/ubuntu/sf237119-test

  [Regression Potential]

  The opportunity for regression is low. The Micron support is
  implemented as a plugin for the application and the changes are more
  or less standalone. The code paths can only be accessed via "nvme
  micron" subcommands.

  If a regression happens, then users should refrain from running "nvme
  micron" commands while the package is fixed.

  [Other Info]

  The commit that adds support for Micron drives is:

  commit 0124daa3331602365d009a9e8229454c41931c07
  Author: Stephen Tubbs <stubbs@xxxxxxxxxx>
  Date:   Wed May 9 07:06:03 2018 -0700
  Subject: Add support for Micron plugin

  https://github.com/linux-nvme/nvme-
  cli/commit/0124daa3331602365d009a9e8229454c41931c07

  This commit landed in version 1.6, and is present in the following
  distros:

  $ rmadison nvme-cli -a amd64
  nvme-cli | 1.5-1 | bionic/universe | amd64
  nvme-cli | 1.6-1 | cosmic/universe | amd64
  nvme-cli | 1.7-1 | disco/universe  | amd64
  nvme-cli | 1.7-1 | eoan/universe   | amd64

  There is a minor backport required for the commit into version 1.5,
  and that is in the Makefile. Some other plugins which are not
  currently present are in the patch, and needed to be removed from the
  OBJS line.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/nvme-cli/+bug/1838555/+subscriptions