sts-sponsors team mailing list archive
-
sts-sponsors team
-
Mailing list archive
-
Message #01575
[Bug 1858802] Re: libblkid: no bcache UUID due to ambivalent detection of bcache and xfs_external_log for regular xfs in bcache backing device
The autopkgtest failures for focal are unrelated to this upload.
- piuparts/1.1.0:
There's changes from piuparts 1.1.0 to 1.1.1 (released a few hours ago)
that resolved the issues, as seen in the autopkgtests page for piuparts.
Requested re-runs.
- openjdk:
The failing test timed-out on armhf and is reported as FLAKY in the log; requested re-run.
(openjdk probably is not checking for XFS filesystems on bcache devices :)
autopkgtest [09:28:36]: ERROR: timed out on command "<...>
autopkgtest [09:28:36]: test jdk: -----------------------]
autopkgtest [09:28:40]: test jdk: - - - - - - - - - - results - - - - - - - - - -
jdk FLAKY timed out
- cmake-extras/1.3+17.04.20170310-5:
There's changes in focal-proposed (cmake-extras 1.3+17.04.20170310-7) that address autopkgtest failures, but looking at its test log, it fixed 1 of 2 failures (fixed 'copyrighttest' but not 'includechecker', and regressed 'findgmock'. so _not_ requesting re-runs.
Thus apparently not quite there yet; but anyway, not XFS/bcache either.
--
You received this bug notification because you are a member of STS
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1858802
Title:
libblkid: no bcache UUID due to ambivalent detection of bcache and
xfs_external_log for regular xfs in bcache backing device
Status in util-linux package in Ubuntu:
In Progress
Status in util-linux source package in Xenial:
In Progress
Status in util-linux source package in Bionic:
In Progress
Status in util-linux source package in Disco:
In Progress
Status in util-linux source package in Eoan:
In Progress
Status in util-linux source package in Focal:
In Progress
Status in util-linux package in Debian:
Unknown
Bug description:
[Impact]
* Users with an XFS filesystem on top of bcache
(this is seen on some ceph, cloud deployments)
might fail to reference the bcache device by
UUID or other udev properties.
* The journal of the regular XFS filesystem in
the bcache device is incorrectly detected as
an XFS external log; so two superblocks are
detected (bcache and xfs_external_log).
* Thus blkid fails with ambivalent superblocks
detected then doesn't provide the usual udev
properties (UUID, etc.)
* The fix improves the probe function for XFS
external log so it detects it's regular XFS
and bails out.
[Test Case]
* See test steps detailed in comment #7 and later.
- Create an XFS filesystem with the journal/log
in the beginning of the bcache device (< 256K).
- Stop the bcache device.
- Run '$ blkid -o udev -p $BCACHE_BACKING_DEVICE'.
$ sudo make-bcache -B $BACKING_DEV
$ sudo mkfs.xfs -d agsize=16m -l agnum=0 -f $BCACHE_DEV
$ echo 1 | sudo tee /sys/block/$(basename $BCACHE_DEV)/bcache/stop
$ sudo blkid -o udev -p $BACKING_DEV
[Regression Potential]
* The patch only changes the detection function
for XFS external log to be more general about
the sector where the magic of regular XFS may
be found (which is shifted inside the bcache.)
* It still checks at sector zero (the only one
checked previously), so this behavior didn't
change.
* Possible regressions are actual XFS external
log devices that are not anymore detected as
such. (Although that would probably indicate
a different bug in libblkid.)
[Other Info]
* upstream commit:
https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/commit/?id=d756af7d640c51ce8d1414607bd3f17eeecf2424
To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/util-linux/+bug/1858802/+subscriptions