sts-sponsors team mailing list archive

[Kellen Renshaw <1860813@xxxxxxxxxxxxxxxxxx>]

Test for 19.10/eoan

Autopkgtests:
autopkgtest [16:38:08]: test exercise: -----------------------]
autopkgtest [16:38:08]: test exercise:  - - - - - - - - - - results - - - - - - - - - -
exercise             PASS
autopkgtest [16:38:08]: @@@@@@@@@@@@@@@@@@@@ summary
exercise             PASS


Manual test:
ubuntu@test-lxcfs-eoan:~$ lxc launch ubuntu:e test1
ubuntu@test-lxcfs-eoan:~$ lxc shell test1 # opened two in separate sessions
Session 1
root@test1:~# watch -n 0.1 "grep Swap /proc/meminfo"

Session 2
root@test1:~# while true; do free | grep Swap; done
...
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
...

# note, doesn't seem to be reproducing on this machine, has for others

ubuntu@test-lxcfs-eoan:~$ sudo apt install ./lxcfs_3.0.4-2ubuntu1_amd64.deb
ubuntu@test-lxcfs-eoan:~$ dpkg -l | grep lxcfs
ii  lxcfs                                3.0.4-2ubuntu1                         amd64        FUSE based filesystem for LXC
ubuntu@test-lxcfs-eoan:~$ lxc stop test1
ubuntu@test-lxcfs-eoan:~$ lxc start test1
ubuntu@test-lxcfs-eoan:~$ lxc shell test1 # opened two in separate sessions
Session 1
root@test1:~# watch -n 0.1 "grep Swap /proc/meminfo"

Session 2
root@test1:~# while true; do free | grep Swap; done
...
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
Swap:       2097148           0     2097148
...

** Patch added: "lp1860813_eoan.debdiff"
   https://bugs.launchpad.net/ubuntu/+source/lxcfs/+bug/1860813/+attachment/5343854/+files/lp1860813_eoan.debdiff

-- 
You received this bug notification because you are a member of STS
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1860813

Title:
  LXC container reports spike in swap occasionally

Status in lxcfs package in Ubuntu:
  Fix Released
Status in lxcfs source package in Xenial:
  Invalid
Status in lxcfs source package in Bionic:
  In Progress
Status in lxcfs source package in Eoan:
  In Progress

Bug description:
  [Impact]

   * lxcfs provides a container-specific view of /proc/meminfo.
  Occasionally, with near zero or zero swap usage *and* swap accounting
  turned on (kernel parameter swapaccount=1), the container will report
  100% swap utilization.

   * This issue has been encountered and could result in unecessary
  alerts or potential automated attempts at remediating a non-existent
  "full swap" issue.

   * This fix changed the logic used for SwapFree when swap accounting
  is enabled to better handle situations where memswusage is less than
  memusage, caused by the fuzziness of the usage_in_bytes counters used
  as the source. Specifically, it added a check for memusage being
  larger than memswusage and if so, sets 0 as the value of swapusage.
  Otherwise the calculation (memswusage - memusage) remains the same.

  [Test Case]

   * Requires a Bionic (18.04) or Eoan (19.10) host with swap space.

   * Enable swap accounting with the "swapaccount=1" kernel parameter on
  the kernel command line. Edit /etc/default/grub, add "swapaccount=1"
  to the GRUB_CMDLINE_LINUX_DEFAULT="other parameters" line, then run
  "update-grub" and reboot to make the change active.

   * Ensure lxd is installed, "sudo apt install lxd"

   * Create a lxd/lxc container with "lxc launch ubuntu:X
  container_name" with X being either b[ionic] or e[oan].

   * Open two shells to the container with "lxc shell container_name"

   * In one of the shells, run: watch -n 0.1 "grep Swap /proc/meminfo"

   * In the other, run: while true; do free; done

   * You should see SwapFree intermittently drop to zero in the first
  terminal.

   * The fix results in small non-zero swap "usage" intermittently
  instead of intermittent SwapFree = 0.

  
  [Regression Potential] 

   * Low, as swap accounting must be enabled to encounter the bug and
  the fix.

   * Potential for unanticipated edge cases in the values of memusage
  and memswusage to cause incorrect swap reporting within the container,
  with swap accounting turned on.

   * Any tooling that expected, compensated, or relied on the behavior
  may no longer work as expected.

  [Other Info]
   
   * Cherrypick of a one line fix to address this specific situation.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/lxcfs/+bug/1860813/+subscriptions