sts-sponsors team mailing list archive

[Mauricio Faria de Oliveira <1879987@xxxxxxxxxxxxxxxxxx>]

Verification done for xenial:

xenial-updates:

- boots fine w/ console=ttyS0, can ssh in 10 seconds.
- boot fails w/ console=ttyS1, cannot SSH, qemu on 100% CPU (initramfs-tools looping)

xenial-proposed:

- boots fine w/ console=ttyS0, can ssh in 10 seconds. (no regression)
- boots fine w/ console=ttyS1, can ssh in 10 seconds, qemu on low CPU% (issue fixed)

details:
-------

$ lsb_release -cs
xenial

xenial-updates:
---

$ dpkg -s initramfs-tools | grep -i version:
Version: 0.122ubuntu8.16

console=ttyS0:

	$ cat /proc/cmdline
	BOOT_IMAGE=/boot/vmlinuz-4.4.0-184-generic root=UUID=c763ea2f-6085-4419-8895-3cefa32d1477 ro console=ttyS0

console=ttyS1:

	(cannot SSH into system. CPU% always high for QEMU.)
	
	$ top -b -d1 | grep -e CPU -e qemu
	    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
	 143433 libvirt+  20   0 3886900 366840  22900 S 106.7   2.3   0:32.52 qemu-system-x86
	    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
	 143433 libvirt+  20   0 3886900 366840  22900 S 101.0   2.3   0:33.54 qemu-system-x86
	    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
	 143433 libvirt+  20   0 3886900 366840  22900 S 100.0   2.3   0:34.55 qemu-system-x86
	    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
	 143433 libvirt+  20   0 3886900 366840  22900 S 100.0   2.3   0:35.56 qemu-system-x86
	    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
	 143433 libvirt+  20   0 3886900 366840  22900 S 101.0   2.3   0:36.57 qemu-system-x86
	^C

xenial-proposed:
---

$ dpkg -s initramfs-tools | grep -i version:
Version: 0.122ubuntu8.17

console=ttyS0:

	$ cat /proc/cmdline
	BOOT_IMAGE=/boot/vmlinuz-4.4.0-184-generic root=UUID=c763ea2f-6085-4419-8895-3cefa32d1477 ro console=ttyS0

console=ttyS1:

        (can SSH into system. CPU% low for QEMU)

	$ cat /proc/cmdline
	BOOT_IMAGE=/boot/vmlinuz-4.4.0-184-generic root=UUID=c763ea2f-6085-4419-8895-3cefa32d1477 ro console=ttyS1

	 143646 libvirt+  20   0 4596800 692248  22972 R 158.4   4.3   0:53.95 qemu-system-x86
	    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
	 143646 libvirt+  20   0 4596800 692248  22972 S 104.0   4.3   0:55.00 qemu-system-x86
	    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
	 143646 libvirt+  20   0 4596800 692248  22972 S   2.0   4.3   0:55.02 qemu-system-x86
	    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
	 143646 libvirt+  20   0 4596800 692248  22972 S   2.0   4.3   0:55.04 qemu-system-x86
	    PID USER      PR  NI    VIRT    RES    SHR S  %CPU  %MEM     TIME+ COMMAND
	 143646 libvirt+  20   0 4596800 692248  22972 S  37.3   4.3   0:55.42 qemu-system-x86



** Tags removed: verification-needed verification-needed-xenial
** Tags added: verification-done verification-done-xenial

-- 
You received this bug notification because you are a member of STS
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1879987

Title:
  machine get stuck at boot if specified 'console=ttyS* ' doesn't exist.

Status in initramfs-tools package in Ubuntu:
  Fix Released
Status in initramfs-tools source package in Trusty:
  Won't Fix
Status in initramfs-tools source package in Xenial:
  Fix Committed
Status in initramfs-tools source package in Bionic:
  Fix Committed
Status in initramfs-tools source package in Eoan:
  Won't Fix
Status in initramfs-tools source package in Focal:
  Fix Released
Status in initramfs-tools source package in Groovy:
  Fix Released

Bug description:
  [Impact]

  * Currently, if users provide the wrong console in kernel command-line
  (like console=ttyS1, when the right one is ttyS0) *and* "quiet"
  parameter is not provided, we may face an infinite loop on initramfs-
  tools, effectively blocking the boot.

  * Details are: the _log_msg() functions is "void" typed, which means it returns whatever its last command returns; this function is the basic building block for all error/warning messages in initramfs-tools. In case a bad console was provided to kernel on command-line, printf (and apparently all write()-related functions) returns error, and so this error is carried over in _log_msg().
   
  * Happens that checkfs() function has a loop that runs forever in this scenario (*if* fsck is not present in initramfs, and obviously if "quiet" is not provided in the command-line). The situation is easily reproducible.

  * This SRU proposes a pretty simple fix: return zero on _log_msg(). We
  should definitely not brake the boot due to error log functions.

  
  [Test Case]

  * To reproduce this, one must boot a system (virtual machine is good)
  with the wrong console set on kernel command-line through the
  "console=" parameter *and* not pass the "quiet" parameter.

  * Also, e2fsck tool shouldn't be present in the initrd - for that, the
  6th field of /etc/fstab (fs_passno) should be 0 and initrd must be
  recreated after that. This is the default in Ubuntu, though.

  
  [Regression Potential]

  * The regression potential is small, we're just returning 0 after a
  printf that is executed in error paths, so I don't expect any issues
  from that. But in case something bad happens after this change, I
  expect a more friendly" breakage, like an initramfs panic (drop to a
  shell), not a silent failure or boot-loop.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/initramfs-tools/+bug/1879987/+subscriptions