sts-sponsors team mailing list archive

[Eric Desrochers <1913581@xxxxxxxxxxxxxxxxxx>]

[VERIFICATION FOCAL]

In focal, systemd is shipped as follow:

ls -altr /usr/bin/systemd-resolve 
lrwxrwxrwx 1 root root 10 Jan  6 20:47 /usr/bin/systemd-resolve -> resolvectl

With the proposed package of sosreport, the systemd plugin prefer
'resolvectl' over 'systemd-resolve' as it should.

# sos.log
2021-02-18 14:21:53,815 INFO: [plugin:systemd] added cmd output 'resolvectl status'
2021-02-18 14:21:53,815 INFO: [plugin:systemd] added cmd output 'resolvectl statistics'
2021-02-18 14:21:56,377 INFO: [plugin:systemd] collecting output of 'resolvectl status'
2021-02-18 14:21:56,391 INFO: [plugin:systemd] collecting output of 'resolvectl statistics'

ls -altr sos_commands/systemd/resolvectl_stat*
-rw-r--r-- 1 root root 1806 Feb 18 14:21 sos_commands/systemd/resolvectl_status
-rw-r--r-- 1 root root  391 Feb 18 14:21 sos_commands/systemd/resolvectl_statistics

Each command run well and collected the desired output.


If I intentionally remove of the equation and make 'resolvectl' no longer exist. The plugin is taking 'systemd-resolve' as fallback.

# sos.log 
2021-02-18 14:25:30,816 INFO: [plugin:systemd] collecting output of 'systemd-resolve --status'
2021-02-18 14:25:30,830 INFO: [plugin:systemd] collecting output of 'systemd-resolve --statistics'


** Tags removed: verification-needed-focal
** Tags added: verification-done-focal

-- 
You received this bug notification because you are a member of STS
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1913581

Title:
  [plugin][systemd] prefer resolvectl over systemd-resolve

Status in sosreport package in Ubuntu:
  Fix Released
Status in sosreport source package in Bionic:
  In Progress
Status in sosreport source package in Focal:
  Fix Committed
Status in sosreport source package in Groovy:
  Fix Committed
Status in sosreport source package in Hirsute:
  Fix Released
Status in sosreport package in Debian:
  Unknown

Bug description:
  [Impact]

  'resolvectl' has been introduced in systemd v239. Hence 'systemd-
  resolve' is now considered deprecated.

  In Ubuntu (Focal and onward), to accommodate the transition, a symlink
  has been created as follows:

  $ ls -altr /usr/bin/systemd-resolve
  lrwxrwxrwx 1 root root 10 Jul  6  2020 /usr/bin/systemd-resolve -> resolvectl

  
  In stable releases we have systemd version lt and gt v239:

  #systemd-resolve (wo/ resolvectl cmd):
   systemd | 229-4ubuntu21.27 | xenial-security
   systemd | 229-4ubuntu21.29 | xenial-updates
   systemd | 237-3ubuntu10    | bionic
   systemd | 237-3ubuntu10.38 | bionic-security
   systemd | 237-3ubuntu10.44 | bionic-updates

  #resolvectl (w/ resolvectl and the symlink for 'systemd-resolve'):
   systemd | 245.4-4ubuntu3   | focal
   systemd | 245.4-4ubuntu3.4 | focal-updates
   systemd | 246.6-1ubuntu1   | groovy
   systemd | 246.6-1ubuntu1.1 | groovy-updates
   systemd | 247.1-4ubuntu1   | hirsute

  [Test case]

  * Deploy Ubuntu (A container will do)
  * Run sosreport and make sure the systemd plugin is executed
    ** sosreport -a 
    ** sosreport -o systemd
  * Look the content of the generated tarball under 'path_to_sosreport/sos_commands/systemd/'

  And you'll find the output of 'systemd'resolve' for statistics and
  status.

  What we want is to sosreport to prefer 'resolvectl' iff it
  exists/executable.

  [Where problem could occur]

  This 'sos' change enable 'resolvectl' as the preference but remains
  backward compatible with 'systemd-resolve' for system with systemd
  version lt v239.

  If a problem have to occur, it will only be impacting the systemd
  plugin itself, not the core functionalities of 'sos' nor its other
  plugins.

  [Other information]

  Upstream:
  https://github.com/sosreport/sos/pull/2385
  https://github.com/sosreport/sos/pull/2385/commits

  Debian:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=979264

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/sosreport/+bug/1913581/+subscriptions