sts-sponsors team mailing list archive

[Ponnuvel Palaniyappan <1913284@xxxxxxxxxxxxxxxxxx>]

The problem is that IndependentPlugin is not working in Focal's
sosreport. The bcache plugin uses IndependentPlugin (as in, it's not
tied to any specific Distro).

IndependentPlugin was broken at some point since Bionic and has been fixed upstream in https://github.com/sosreport/sos/commit/a36e1b83040f3f2c63912d4601f4b33821cd4afb
(it's working on Bionic).

However, the sos report package on Focal, Groovy, and Hirsute all have
the broken code.

We can fix this in one of the two ways:
- Sync sosreport source with upstream on Focal, Groovy, and Hirsute to fix IndepedentPlugin
- Change bcache to specify individual subclasses (DebianPlugin, UbuntuPlugin, RedhatPlugin, etc)

-- 
You received this bug notification because you are a member of STS
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1913284

Title:
  [plugin] [bcache] add a new bcache plugin

Status in sosreport package in Ubuntu:
  Fix Released
Status in sosreport source package in Bionic:
  New
Status in sosreport source package in Focal:
  Fix Committed
Status in sosreport source package in Groovy:
  Fix Committed
Status in sosreport source package in Hirsute:
  Fix Released

Bug description:
  [Impact]

  Gather bcache stats as part of sos report.

  Bcache is often deployed as a "frontend" (typically using SSDs) for
  Ceph cluster's with HDDs to improve performance. When we are dealing
  with bcache performance or need to debug bcache, these stats are
  essential to identify the problem. The newly added plugin collects
  various stats on bcache.

  
  [Test Case]

  It's a new plugin. When sosreport is run on a system with bcache, a
  number of small files from /sys/fs/bcache and /sys/block/bcache should
  be collected with this plugin in place. On systems, without bcache,
  this should be a no-op.

  
  [Where problems could occur]

  Worst case scenarios could be:
  - As with any plugin, this plugin, in theory, could potentially run indefinitely and timeout.
  - Affect performance when run on a live system. There's one known case where querying the proiorty_stats [0] had such a problem. But it's not collected as part of this plugin.

  But otherwise, the stats collection of bcache devices (even if there
  are many bcache devices deployed on a system) shouldn't affect
  anything on a live system and shouldn't get anywhere closer to
  timeout.

  
  [Other Info]
   
  upstream PR (merged): https://github.com/sosreport/sos/pull/2384


  [0] https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1840043

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/sosreport/+bug/1913284/+subscriptions