sts-sponsors team mailing list archive

[Launchpad Bug Tracker <1928708@xxxxxxxxxxxxxxxxxx>]

You have been subscribed to a public bug by Eric Desrochers (slashd):

Please backport sanlock 3.8.2-2 (universe) from hirsute to focal,
groovy.

Reason for the backport:
========================
sanlock 3.6 in Focal/Groovy is missing flags for specifying sector size, which allows specifying lease alignments and using "mixed" disks with differing logical and physical sector sizes (e.g. a 512/4k SAN disk). This has been added with the commit below:
* 445e86700fa3 - configurable sector size and align size [0]

Unfortunately, the commit above is extremely complex and changes a lot of sanlock internals on how it handles leases and lockspaces, so it's hard to backport individual changes in isolation. In addition to that, commit d5e4def0d087 has a very tight dependecy on:
* d5e4def0d087 - sanlock: add flags to specify sector size [1]

...which is simmilarly complex and introduces lots of changes to paxos
lease internals and other locking-critical structures. Both of these
commits are already present in sanlock 3.8, and it builds directly on
the older releases without any changes to debian/ files, so it's a much
safer choice to simply backport the entire package directly. This avoids
the possibility of introducing any tricky regressions or faulty edge-
cases due to a partial backport, and benefits the older releases with
the new features introduced in sanlock.

[0] https://pagure.io/sanlock/c/445e86700fa3
[1] https://pagure.io/sanlock/c/d5e4def0d087

Testing:
========
Mark off items in the checklist [X] as you test them, but please leave the checklist so that backporters can quickly evaluate the state of testing.

You can test-build the backport in your PPA with backportpackage:
$ backportpackage -u ppa:<lp username>/<ppa name> -s hirsute -d focal sanlock
$ backportpackage -u ppa:<lp username>/<ppa name> -s hirsute -d groovy sanlock

* focal:
[x] Package builds without modification
[x] libsanlock1 installs cleanly and runs
[x] libsanlock-client1 installs cleanly and runs
[x] sanlock installs cleanly and runs
[x] libsanlock-dev installs cleanly and runs
[x] python3-sanlock-dbgsym installs cleanly and runs
[x] sanlock-dbgsym installs cleanly and runs
[x] libsanlock1-dbgsym installs cleanly and runs
[x] libsanlock-client1-dbgsym installs cleanly and runs
[x] python3-sanlock installs cleanly and runs
* groovy:
[x] Package builds without modification
[x] libsanlock1 installs cleanly and runs
[x] libsanlock-client1 installs cleanly and runs
[x] sanlock installs cleanly and runs
[x] libsanlock-dev installs cleanly and runs
[x] python3-sanlock-dbgsym installs cleanly and runs
[x] sanlock-dbgsym installs cleanly and runs
[x] libsanlock1-dbgsym installs cleanly and runs
[x] libsanlock-client1-dbgsym installs cleanly and runs
[x] python3-sanlock installs cleanly and runs

Note: there are PPA builds for this backport request on
ppa:halves/lp1920047 [2] for both Focal and Groovy. Both were tested
with their respective lvm2-lockd versions, on 512 and 4k sector size
disks.

[2] https://launchpad.net/~halves/+archive/ubuntu/lp1920047

Reverse dependencies:
=====================
The following reverse-dependencies need to be tested against the new version of sanlock. For reverse-build-dependencies (-Indep), please test that the package still builds against the new sanlock. For reverse-dependencies, please test that the version of the package currently in the release still works with the new sanlock installed. Reverse- Recommends, Suggests, and Enhances don't need to be tested, and are listed for completeness-sake.

libsanlock1
-----------

libsanlock-client1
------------------
* lvm2-lockd
  [x] focal (Reverse-Depends)
  [x] groovy (Reverse-Depends)
* libvirt-sanlock
  [ ] focal (Reverse-Depends)
  [ ] groovy (Reverse-Depends)

sanlock
-------

libsanlock-dev
--------------
* libvirt
  [ ] focal (Reverse-Build-Depends)
  [ ] groovy (Reverse-Build-Depends)
* lvm2
  [ ] focal (Reverse-Build-Depends)
  [ ] groovy (Reverse-Build-Depends)

python3-sanlock-dbgsym
----------------------

sanlock-dbgsym
--------------

libsanlock1-dbgsym
------------------

libsanlock-client1-dbgsym
-------------------------

python3-sanlock
---------------

** Affects: focal-backports
     Importance: Undecided
         Status: New

** Affects: groovy-backports
     Importance: Undecided
         Status: New


** Tags: sts
-- 
Please backport sanlock 3.8.2-2 (universe) from hirsute
https://bugs.launchpad.net/bugs/1928708
You received this bug notification because you are a member of STS Sponsors, which is subscribed to the bug report.