sts-sponsors team mailing list archive

[Lukas Märdian <1771740@xxxxxxxxxxxxxxxxxx>]

I've tested netplan.io 0.103-0ubuntu7.1 from impish-proposed and
attached the autopkgtest logs to the bug description, according to
https://wiki.ubuntu.com/NetplanUpdates.

The netplan generator command was run successfully, producing correct
*Offload=1 settings for networkd.

root@sru-ii:~# dpkg -l | grep netplan
ii libnetplan0:amd64 0.103-0ubuntu7.1 amd64 YAML network configuration abstraction runtime library
ii netplan.io 0.103-0ubuntu7.1 amd64 YAML network configuration abstraction for various backends

root@sru-ii:~# cat tmp/etc/netplan/test.yaml 
network:
  version: 2
  ethernets:
    eth1:
      receive-checksum-offload: true
      transmit-checksum-offload: true
      tcp-segmentation-offload: true
      tcp6-segmentation-offload: true
      generic-segmentation-offload: true
      generic-receive-offload: true
      large-receive-offload: true
root@sru-ii:~# /usr/lib/netplan/generate -r tmp/
root@sru-ii:~# cat tmp/run/systemd/network/10-netplan-eth1.link | grep Offload
ReceiveChecksumOffload=1
TransmitChecksumOffload=1
TCPSegmentationOffload=1
TCP6SegmentationOffload=1
GenericSegmentationOffload=1
GenericReceiveOffload=1
LargeReceiveOffload=1

** Tags removed: verification-needed-impish
** Tags added: verification-done-impish

-- 
You received this bug notification because you are a member of STS
Sponsors, which is subscribed to the bug report.
https://bugs.launchpad.net/bugs/1771740

Title:
  Expose link offload options

Status in netplan:
  Fix Committed
Status in netplan.io package in Ubuntu:
  Fix Released
Status in netplan.io source package in Focal:
  Fix Committed
Status in netplan.io source package in Hirsute:
  Fix Committed
Status in netplan.io source package in Impish:
  Fix Committed
Status in netplan.io source package in Jammy:
  Fix Released

Bug description:
  [Impact]

   * On virtualization hosts disable GRO and LRO, otherwise, with
     receive offload on, the guests will receive packets that are
     larger than the MTU. This can cause issues in certain scenarios,
     e.g. when the guest is a VPN server that needs to forward the
     (inner) packet onward.

  [Test Plan]
  In addition to runing & passing the full set of unit- and integration-tests
  (that contains new tests to check for this new feature), as described in
  https://wiki.ubuntu.com/NetplanUpdates we want to run the following commands
  to make sure the link offload stanza is working properly:

  $ mkdir -p tmp/etc/netplan
  $ cat tmp/etc/netplan/test.yaml
  network:
    version: 2
    ethernets:
      eth1:
        receive-checksum-offload: true
        transmit-checksum-offload: true
        tcp-segmentation-offload: true
        tcp6-segmentation-offload: true
        generic-segmentation-offload: true
        generic-receive-offload: true
        large-receive-offload: true
  $ /usr/lib/netplan/generate -r tmp/
  $ cat tmp/run/systemd/network/10-netplan-eth1.link | grep Offload

  => Make sure the *Offload settings are correctly set to "=1".

  autopkgtest logs:
  * Impish:
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/impish_amd64.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/impish_arm64.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/impish_armhf.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/impish_ppc64el.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/impish_s390x.log
  * Hirsute:
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/hirsute_amd64.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/hirsute_arm64.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/hirsute_armhf.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/hirsute_ppc64el.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/hirsute_s390x.log
  * Focal:
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/focal_amd64.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/focal_arm64.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/focal_armhf.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/focal_ppc64el.log
  https://git.launchpad.net/~slyon/+git/files/tree/LP1949104/focal_s390x.log

  [Where problems could occur]

   * The settings exist since systemd-232 which means Bionic and up can use
     this feature

  This upload touches netplan's generator, if anything goes wrong it could impact
  the rendering of network configuration and break a system's network connectivity

  [Other Info]
  The full set of autopkgtest logs will be attached after the upload is accepted
  into -proposed and the tests have been run on the official autopkgtest.u.c
  infrastructure.

  This also contains partial-d4884cfd40e1e33540b274371c3272df6595d22c.patch, to
  keep libnetplan's ABI forward compatible with current upstream/Github, by
  partially cherry-picking the ignore_carrier field addition into the
  NetplanNetDefinition struct.

  === Original Description ===

  https://www.freedesktop.org/software/systemd/man/systemd.link.html has a
  number of [Link] options which I need to use for a flaky network card
  (TCPSegmentationOffload, TCP6SegmentationOffload,
  GenericSegmentationOffload, GenericReceiveOffload, LargeReceiveOffload)
  which are not exposed via netplan.

To manage notifications about this bug go to:
https://bugs.launchpad.net/netplan/+bug/1771740/+subscriptions