sts-sponsors team mailing list archive

[Alberto Donato <mp+433603@xxxxxxxxxxxxxxxxxx>]

Review: Approve

+1 with a small nit

Diff comments:

> diff --git a/src/maasserver/management/commands/config_vault.py b/src/maasserver/management/commands/config_vault.py
> index 6619345..3734d4f 100644
> --- a/src/maasserver/management/commands/config_vault.py
> +++ b/src/maasserver/management/commands/config_vault.py
> @@ -147,10 +148,14 @@ class Command(BaseCommand):
>          """Handles the actual secrets migration"""
>  
>          print("Migrating secrets")
> +        metadata = []
>          for secret in Secret.objects.all():
>              client.set(secret.path, secret.value)
> +            metadata.append(VaultSecret(path=secret.path, deleted=False))
>              secret.delete()
>  
> +        VaultSecret.objects.bulk_create(metadata, ignore_conflicts=True)

ignore_conflicts shouldn't really be needed, as no object exists at that point?

> +
>          # Enable Vault cluster-wide
>          Config.objects.set_config("vault_enabled", True)
>  


-- 
https://code.launchpad.net/~igor-brovtsin/maas/+git/maas/+merge/433603
Your team MAAS Committers is subscribed to branch maas:master.