← Back to team overview

sts-sponsors team mailing list archive

[Merge] ~bjornt/maas:test_handles_missing_system_handler_on_notification-debug into maas:master

 

Björn Tillenius has proposed merging ~bjornt/maas:test_handles_missing_system_handler_on_notification-debug into maas:master.

Commit message:
Add debug logging to test_handles_missing_system_handler_on_notification.

It sometimes fails intermittently. I have a theory on why, but I want to see
some debug logs from a failure to confirm my finding, since I can't reproduce
it locally.



Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/433741
-- 
Your team MAAS Committers is subscribed to branch maas:master.
diff --git a/src/maasserver/tests/test_listener.py b/src/maasserver/tests/test_listener.py
index 626b73f..ab9b473 100644
--- a/src/maasserver/tests/test_listener.py
+++ b/src/maasserver/tests/test_listener.py
@@ -66,9 +66,11 @@ class PostgresListenerServiceSpy(PostgresListenerService):
         self.notifications = frozenset()
 
     def _process_notifies(self):
+        self.log.debug("Start processing notifies for tests")
         for notify in self.connection.connection.notifies:
             self._captured_notifies.put(notify)
         super()._process_notifies()
+        self.log.debug("Done processing notifies for tests")
 
     @inlineCallbacks
     def wait_notification(self, channel):
@@ -76,6 +78,7 @@ class PostgresListenerServiceSpy(PostgresListenerService):
         while True:
             notice = yield self._captured_notifies.get()
             if notice.channel == channel:
+                self.log.debug(f"Found a notification for channel {channel}")
                 returnValue(notice)
 
 

Follow ups