sts-sponsors team mailing list archive

[Alberto Donato <mp+433853@xxxxxxxxxxxxxxxxxx>]

Review: Approve

nice, +1

Diff comments:

> diff --git a/Makefile b/Makefile
> new file mode 100644
> index 0000000..9821888
> --- /dev/null
> +++ b/Makefile
> @@ -0,0 +1,41 @@
> +VIRTUALENV := .ve
> +CHECK_OUTPUT = output-check
> +
> +.DEFAULT_GOAL := setup
> +
> +install-dependencies:
> +	sudo apt-get -y install python3-venv
> +
> +clean:
> +	rm -rf $(VIRTUALENV)
> +
> +setup: py-dep jenkins-jobs
> +
> +check: setup
> +	rm -rf $(CHECK_OUTPUT)
> +	./jenkins-jobs test -r --config-xml -o $(CHECK_OUTPUT) jobs/
> +
> +py-dep: $(VIRTUALENV)
> +	$(VIRTUALENV)/bin/pip install -r requirements.txt
> +
> +jenkins-jobs: $(VIRTUALENV)/.dev-bin
> +	ln -fs $(VIRTUALENV)/bin/jenkins-jobs
> +
> +

extra empty lien

> +$(VIRTUALENV):
> +	python3 -m venv $(VIRTUALENV)
> +
> +$(VIRTUALENV)/.dev-bin:
> +	$(MAKE) py-dep
> +	touch $@
> +
> +py-freeze: VENV := .freeze_ve
> +py-freeze: PIP := $(VENV)/bin/pip
> +py-freeze:
> +	rm -rf $(VENV)
> +	python3 -m venv $(VENV)
> +	$(PIP) install jenkins-job-builder
> +	$(PIP) freeze | grep -E -v '^pkg-resources' > requirements.txt
> +	rm -rf $(VENV)
> +.PHONY: py-freeze
> +


-- 
https://code.launchpad.net/~bjornt/maas-ci/+git/maas-ci-internal/+merge/433853
Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-internal:main.