sts-sponsors team mailing list archive

[Björn Tillenius <mp+433857@xxxxxxxxxxxxxxxxxx>]

Review: Approve

+1 with a suggestion inline.

Diff comments:

> diff --git a/Makefile b/Makefile
> index 305f416..842db32 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -13,7 +13,7 @@ setup: py-dep jenkins-jobs
>  
>  check: setup
>  	rm -rf $(CHECK_OUTPUT)
> -	./jenkins-jobs test -r --config-xml -o $(CHECK_OUTPUT) jobs/
> +	./jenkins-jobs test -r --config-xml -o $(CHECK_OUTPUT) 'jobs/:globals.yaml'

Doesn't it work if you put globals.yaml in jobs/? Or maybe if we pass in './' instead of 'jobs]'? It'd be good to keep the update and test commands as simple as possible.

>  
>  py-dep: $(VIRTUALENV)
>  	$(VIRTUALENV)/bin/pip install -r requirements.txt


-- 
https://code.launchpad.net/~ack/maas-ci/+git/maas-ci-internal/+merge/433857
Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-internal:main.