sts-sponsors team mailing list archive

[Björn Tillenius <mp+433860@xxxxxxxxxxxxxxxxxx>]

Review: Approve

+1 with a comment inline.

Diff comments:

> diff --git a/jobs/ws-machine-listing-spike-rebase.yaml b/jobs/ws-machine-listing-spike-rebase.yaml
> new file mode 100644
> index 0000000..44afa1f
> --- /dev/null
> +++ b/jobs/ws-machine-listing-spike-rebase.yaml
> @@ -0,0 +1,24 @@
> +- project:
> +    name: ws-machine-listing-spike
> +    jobs:
> +      - ws-machine-listing-spike
> +
> +- job-template:
> +    name: ws-machine-listing-spike
> +    triggers:
> +      - timed: '@daily'
> +    parameters:
> +        - string:
> +            name: REBASE_BRANCH
> +            description: Branch to rebase
> +            default: ws-machine-listing-spike
> +        - string:
> +            name: BASE_BRANCH
> +            description: Base branch to rebase on
> +            default: master
> +        - string:
> +            name: REPO
> +            description: GIT repository 
> +            default: ~maas-committers/maas

Let's skip the parameters. There's no need to allow rebasing any branch, is there? Especially, we shouldn't allow rebasing master or any of the release branches.

> +    dsl: !include-jinja2: ws-machine-listing-spike-rebase.groovy
> +


-- 
https://code.launchpad.net/~ack/maas-ci/+git/maas-ci-internal/+merge/433860
Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-internal:main.