sts-sponsors team mailing list archive

[Adam Collard <mp+434256@xxxxxxxxxxxxxxxxxx>]

Review: Needs Information



Diff comments:

> diff --git a/src/metadataserver/user_data/templates/snippets/maas_run_scripts.py b/src/metadataserver/user_data/templates/snippets/maas_run_scripts.py
> index 09e8855..dd4e01e 100644
> --- a/src/metadataserver/user_data/templates/snippets/maas_run_scripts.py
> +++ b/src/metadataserver/user_data/templates/snippets/maas_run_scripts.py
> @@ -49,6 +49,7 @@ class ScriptsPaths:
>      def __init__(self, base_path=None):
>          if base_path is None:
>              base_path = Path(mkdtemp())
> +        self.base_path = base_path

if base_path is given to us, and we're not `mkdtemp()`ing I'm not sure we should be rming it?

>          self.scripts = base_path / "scripts"
>          self.out = base_path / "out"
>          self.downloads = base_path / "downloads"


-- 
https://code.launchpad.net/~igor-brovtsin/maas/+git/maas/+merge/434256
Your team MAAS Committers is subscribed to branch maas:master.