sts-sponsors team mailing list archive

[Adam Collard <mp+434563@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> diff --git a/src/maasserver/migrations/maasserver/0291_auto_20221213_1017.py b/src/maasserver/migrations/maasserver/0291_auto_20221213_1017.py
> new file mode 100644
> index 0000000..d0e3903
> --- /dev/null
> +++ b/src/maasserver/migrations/maasserver/0291_auto_20221213_1017.py
> @@ -0,0 +1,23 @@
> +# Generated by Django 3.2.12 on 2022-12-13 10:17
> +
> +from django.db import migrations, models
> +
> +
> +class Migration(migrations.Migration):
> +
> +    dependencies = [
> +        ("maasserver", "0290_migrate_node_power_parameters"),
> +    ]
> +
> +    operations = [
> +        migrations.AddField(
> +            model_name="bootresource",
> +            name="last_deployed",
> +            field=models.DateTimeField(blank=True, null=True),
> +        ),
> +        migrations.AddField(
> +            model_name="node",
> +            name="deploy_time",
> +            field=models.DateTimeField(blank=True, null=True),

Danger Will Robinson - don't think this warrants Yet Another column for node.

Look at EVENT_TYPES.NODE_INSTALLATION_FINISHED

> +        ),
> +    ]
> diff --git a/src/maasserver/websockets/handlers/device.py b/src/maasserver/websockets/handlers/device.py
> index 4d98b8c..ef6d3c0 100644
> --- a/src/maasserver/websockets/handlers/device.py
> +++ b/src/maasserver/websockets/handlers/device.py
> @@ -153,6 +153,7 @@ class DeviceHandler(NodeHandler):
>          list_fields = [
>              "id",
>              "system_id",
> +            "deploy_time",

A device cannot be deployed

>              "hostname",
>              "owner",
>              "domain",


-- 
https://code.launchpad.net/~lloydwaltersj/maas/+git/maas/+merge/434563
Your team MAAS Committers is subscribed to branch maas:master.