sts-sponsors team mailing list archive

[Adam Collard <mp+434563@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> diff --git a/src/maasserver/models/bootresource.py b/src/maasserver/models/bootresource.py
> index 3ec9528..3a6f54f 100644
> --- a/src/maasserver/models/bootresource.py
> +++ b/src/maasserver/models/bootresource.py
> @@ -591,6 +584,16 @@ class BootResource(CleanSave, TimestampedModel):
>                  return resource_set
>          return None
>  
> +    def get_last_deploy(self) -> datetime:
> +        deploy_msg = f"deployed {self.name}/{self.architecture}"
> +        with connection.cursor() as cursor:

don't connect to the DB here - that's a layering violation

you want something like

Event.objects.latest('created', type__name=EVENT_TYPES.IMAGE_DEPLOYED)

> +            cursor.execute(
> +                f"SELECT created FROM maasserver_event WHERE description='{deploy_msg}'"
> +            )
> +            result = cursor.fetchall()
> +            if result:
> +                return max(result)[0]
> +
>      def split_arch(self):
>          return self.architecture.split("/")
>  


-- 
https://code.launchpad.net/~lloydwaltersj/maas/+git/maas/+merge/434563
Your team MAAS Committers is subscribed to branch maas:master.