sts-sponsors team mailing list archive

[Adam Collard <mp+435266@xxxxxxxxxxxxxxxxxx>]

Adam Collard has proposed merging ~adam-collard/maas:empty-power-parameters-2002109 into maas:master.

Commit message:
LP:2002109 Skip empty power parameters

Requested reviews:
  MAAS Maintainers (maas-maintainers)
Related bugs:
  Bug #2002109 in MAAS: "Migration of BMC power credentials fails with manual driver"
  https://bugs.launchpad.net/maas/+bug/2002109

For more details, see:
https://code.launchpad.net/~adam-collard/maas/+git/maas/+merge/435266
-- 
Your team MAAS Committers is subscribed to branch maas:master.

diff --git a/src/maasserver/migrations/maasserver/0290_migrate_node_power_parameters.py b/src/maasserver/migrations/maasserver/0290_migrate_node_power_parameters.py
index 051091a..6cd6f3e 100644
--- a/src/maasserver/migrations/maasserver/0290_migrate_node_power_parameters.py
+++ b/src/maasserver/migrations/maasserver/0290_migrate_node_power_parameters.py
@@ -43,7 +43,9 @@ def move_secrets(apps, schema_editor):
     for bmc_id, power_type, power_parameters in BMC.objects.values_list(
         "id", "power_type", "power_parameters"
     ):
-
+        # LP:2002109 - Manual power driver has empty power parameters
+        if not power_parameters:
+            continue
         secrets = {}
         parameters = {}
         for name, value in power_parameters.items():