sts-sponsors team mailing list archive

[Jack Lloyd-Walters <mp+435166@xxxxxxxxxxxxxxxxxx>]

Review: Approve

Minor inline comment, otherwise LGTM

Diff comments:

> diff --git a/src/provisioningserver/drivers/power/ipmi.py b/src/provisioningserver/drivers/power/ipmi.py
> index 70201e8..2cfdf8c 100644
> --- a/src/provisioningserver/drivers/power/ipmi.py
> +++ b/src/provisioningserver/drivers/power/ipmi.py
> @@ -308,7 +308,7 @@ class IPMIPowerDriver(PowerDriver):
>          ),
>      ]
>      ip_extractor = make_ip_extractor("power_address")
> -    wait_time = (4, 8, 16, 32)
> +    wait_time = (4, 8, 16, 32, 32)

Is there any reason the final wait time is a duplicate of the previous, rather than the next power of two, as the pattern would suggest?

>  
>      def detect_missing_packages(self):
>          if not shell.has_command_available("ipmipower"):


-- 
https://code.launchpad.net/~gschwim/maas/+git/maas/+merge/435166
Your team MAAS Committers is subscribed to branch maas:3.2.