sts-sponsors team mailing list archive

[Jack Lloyd-Walters <mp+435611@xxxxxxxxxxxxxxxxxx>]

Review: Approve

LGTM, minor question inline

Diff comments:

> diff --git a/src/provisioningserver/dns/zoneconfig.py b/src/provisioningserver/dns/zoneconfig.py
> index 3c6e383..6ab01a8 100644
> --- a/src/provisioningserver/dns/zoneconfig.py
> +++ b/src/provisioningserver/dns/zoneconfig.py
> @@ -197,9 +197,16 @@ class DomainConfigBase:
>          if not isinstance(output_file, list):
>              output_file = [output_file]
>          for outfile in output_file:
> +            print(render_dns_template)

Just double checking this print statement is meant to stay in the MP?

>              content = render_dns_template(cls.template_file_name, *parameters)
>              with report_missing_config_dir():
> -                incremental_write(content.encode("utf-8"), outfile, mode=0o644)
> +                incremental_write(
> +                    content.encode("utf-8"),
> +                    outfile,
> +                    mode=0o644,
> +                    uid=os.getuid(),
> +                    gid=os.getgid(),
> +                )
>          pass
>  
>  


-- 
https://code.launchpad.net/~cgrabowski/maas/+git/maas/+merge/435611
Your team MAAS Committers is subscribed to branch maas:master.