← Back to team overview

sts-sponsors team mailing list archive

Re: [Merge] ~emdw/maas:timeout-configuration into maas:master

 


Diff comments:

> diff --git a/src/maasserver/tests/test_sessiontimeout.py b/src/maasserver/tests/test_sessiontimeout.py
> new file mode 100644
> index 0000000..6b487f5
> --- /dev/null
> +++ b/src/maasserver/tests/test_sessiontimeout.py
> @@ -0,0 +1,37 @@
> +# Tests for custom sessionbase to configure timeout

please make these pytest tests

> +
> +from maasserver.sessiontimeout import SessionStore
> +from maasserver.testing.factory import factory
> +from maasserver.testing.testcase import MAASServerTestCase
> +from maasserver.websockets.handlers.config import ConfigHandler
> +
> +
> +class TestSessionTimeout(MAASServerTestCase):
> +    def test_default_config(self):
> +        admin = factory.make_admin()
> +        handler = ConfigHandler(admin, {}, None)
> +        self.assertEqual(
> +            {"name": "session_length", "value": 1209600},
> +            handler.get({"name": "session_length"}),
> +        )
> +
> +    def test_default_cookie_age(self):
> +        admin = factory.make_admin()
> +        handler = ConfigHandler(admin, {}, None)
> +        sess = SessionStore()
> +        default_value = sess.get_session_cookie_age()
> +        self.assertEqual(
> +            {"name": "session_length", "value": default_value},
> +            handler.get({"name": "session_length"}),
> +        )
> +
> +    def test_update_cookie_age(self):
> +        admin = factory.make_admin()
> +        handler = ConfigHandler(admin, {}, None)
> +        sess = SessionStore()
> +        handler.update({"name": "session_length", "value": 50})
> +        value = sess.get_session_cookie_age()
> +        self.assertEqual(
> +            {"name": "session_length", "value": value},
> +            handler.get({"name": "session_length"}),
> +        )


-- 
https://code.launchpad.net/~emdw/maas/+git/maas/+merge/435525
Your team MAAS Committers is subscribed to branch maas:master.



References