← Back to team overview

sts-sponsors team mailing list archive

Re: [Merge] ~bjornt/maas:perf-test-always-run into maas:master

 

Review: Approve

+1 with a suggestion

Diff comments:

> diff --git a/utilities/run-perf-tests-ci b/utilities/run-perf-tests-ci
> index b5162ba..f8f84c1 100755
> --- a/utilities/run-perf-tests-ci
> +++ b/utilities/run-perf-tests-ci
> @@ -29,11 +29,7 @@ echo "MAAS_RAND_SEED=${MAAS_RAND_SEED}"
>  echo "PYTHONHASHSEED=${PYTHONHASHSEED}"
>  
>  bin/pytest \
> -    -q \
> -    --disable-warnings \
> -    --show-capture=no \
> -    --no-header \
> -    --no-summary \
> +    -v \
>      --junit-xml=junit-perf.xml \
>      --maas-recreate-initial-db \
>      --maas-initial-db "${DB_DUMP}" \

maybe we could also add "$@" as a final param to pytest, so one can pass extra options (like -s) to pytest and still use the script?



-- 
https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/436124
Your team MAAS Committers is subscribed to branch maas:master.



References