← Back to team overview

sts-sponsors team mailing list archive

[Merge] ~bjornt/maas:sampledata-vid-error into maas:master

 

Björn Tillenius has proposed merging ~bjornt/maas:sampledata-vid-error into maas:master.

Commit message:
Fix sample data generation to generate valid vids.

MAAS ensures that the vid for VLANs are less than 4095.



Requested reviews:
  MAAS Maintainers (maas-maintainers)

For more details, see:
https://code.launchpad.net/~bjornt/maas/+git/maas/+merge/436255
-- 
Your team MAAS Committers is subscribed to branch maas:master.
diff --git a/src/maasserver/testing/sampledata/network.py b/src/maasserver/testing/sampledata/network.py
index abc86bf..d835efe 100644
--- a/src/maasserver/testing/sampledata/network.py
+++ b/src/maasserver/testing/sampledata/network.py
@@ -25,7 +25,7 @@ def make_networks(
     for fabric in fabrics:
         vlans[fabric] = [
             VLAN.objects.create(vid=vid, fabric=fabric)
-            for vid in random.sample(range(10, 4096), count_per_fabric)
+            for vid in random.sample(range(10, 4095), count_per_fabric)
         ]
         for vlan in vlans[fabric]:
             cidr = factory.make_ipv4_network(slash=24, but_not=created_cidrs)

Follow ups