sts-sponsors team mailing list archive

[Adam Collard <mp+437695@xxxxxxxxxxxxxxxxxx>]

Adam Collard has proposed merging ~adam-collard/maas-ci/+git/maas-ci-internal:split-stages into ~maas-committers/maas-ci/+git/maas-ci-internal:main.

Commit message:
[job-reviewer] Split stages, add optional test



Requested reviews:
  MAAS Lander (maas-lander)
  MAAS Committers (maas-committers)

For more details, see:
https://code.launchpad.net/~adam-collard/maas-ci/+git/maas-ci-internal/+merge/437695
-- 
Your team MAAS Committers is requested to review the proposed merge of ~adam-collard/maas-ci/+git/maas-ci-internal:split-stages into ~maas-committers/maas-ci/+git/maas-ci-internal:main.

diff --git a/jobs/launchpad-ci/job-reviewer.groovy b/jobs/launchpad-ci/job-reviewer.groovy
index d95d000..ef75e32 100644
--- a/jobs/launchpad-ci/job-reviewer.groovy
+++ b/jobs/launchpad-ci/job-reviewer.groovy
@@ -45,7 +45,7 @@ pipeline {
       }
     }
 
-    stage('Unit Test Branches') {
+    stage('Find MPs that need review') {
       steps {
         withCredentials([
           file(credentialsId: 'lp-lander-credentials', variable: 'CREDS'),
@@ -54,15 +54,21 @@ pipeline {
           script {
             env.GIT_SSH_COMMAND = "ssh -i $SSHKEY -o StrictHostKeyChecking=no -o UserKnownHostsFile=/dev/null"
             def output = run('ci/launchpad --credentials $CREDS reviewable-jobs maas-ci-internal/jobs/')
-            def jobs = parseJobs(output)
-            if(jobs.size() > 0) {
-              def builds = [:]
-              for(job in jobs) {
-                builds[job.LP_BRANCH_SRC] = createBuildContextForJob(job)
-              }
-              parallel builds
-            }
+            env._mps_to_review = output
+	  }
+	}
+      }
+    }
+    stage('Test MPs') {
+      when { not { environment name: '_mps_to_review', value: '[]' }}
+      steps {
+	script {
+	  def jobs = parseJobs(env._mps_to_review)
+          def builds = [:]
+          for(job in jobs) {
+            builds[job.LP_BRANCH_SRC] = createBuildContextForJob(job)
           }
+          parallel builds
         }
       }
     }