sts-sponsors team mailing list archive
-
sts-sponsors team
-
Mailing list archive
-
Message #05477
[Merge] ~petermakowski/maas-site-manager:update-fe-lint into maas-site-manager:main
Peter Makowski has proposed merging ~petermakowski/maas-site-manager:update-fe-lint into maas-site-manager:main.
Commit message:
test: add tsc to front-end lint script
- fix: remove empty types.ts file
Requested reviews:
MAAS Committers (maas-committers)
For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/438119
This fixes the most recent failing build due to an empty ts file being commited.
--
Your team MAAS Committers is requested to review the proposed merge of ~petermakowski/maas-site-manager:update-fe-lint into maas-site-manager:main.
diff --git a/frontend/package.json b/frontend/package.json
index 726b091..1991368 100644
--- a/frontend/package.json
+++ b/frontend/package.json
@@ -8,7 +8,7 @@
"test": "vitest",
"coverage": "vitest run --coverage",
"preview": "vite preview",
- "lint": "npmPkgJsonLint . && eslint . --ext .ts,.tsx",
+ "lint": "npmPkgJsonLint . && tsc && eslint . --ext .ts,.tsx",
"lint-fix": "eslint . --ext .ts,.tsx --fix"
},
"dependencies": {
diff --git a/frontend/src/components/SitesList/types.ts b/frontend/src/components/SitesList/types.ts
deleted file mode 100644
index e69de29..0000000
--- a/frontend/src/components/SitesList/types.ts
+++ /dev/null
Follow ups
-
[Merge] ~petermakowski/maas-site-manager:update-fe-lint into maas-site-manager:main
From: Adam Collard, 2023-03-03
-
[Merge] ~petermakowski/maas-site-manager:update-fe-lint into maas-site-manager:main
From: MAAS Lander, 2023-03-02
-
Re: [Merge] -b update-fe-lint lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - LANDING FAILED
From: MAAS Lander, 2023-03-02
-
[Merge] ~petermakowski/maas-site-manager:update-fe-lint into maas-site-manager:main
From: Thorsten Merten, 2023-03-02
-
[Merge] ~petermakowski/maas-site-manager:update-fe-lint into maas-site-manager:main
From: MAAS Lander, 2023-03-01
-
Re: [Merge] -b update-fe-lint lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - LANDING FAILED
From: MAAS Lander, 2023-03-01
-
[Merge] ~petermakowski/maas-site-manager:update-fe-lint into maas-site-manager:main
From: MAAS Lander, 2023-03-01
-
[Merge] ~petermakowski/maas-site-manager:update-fe-lint into maas-site-manager:main
From: Peter Makowski, 2023-03-01
-
Re: [Merge] ~petermakowski/maas-site-manager:update-fe-lint into maas-site-manager:main
From: Nick De Villiers, 2023-03-01
-
Re: [UNITTESTS] -b update-fe-lint lp:~petermakowski/maas-site-manager/+git/site-manager into -b main lp:~maas-committers/maas-site-manager - TESTS PASS
From: MAAS Lander, 2023-03-01
-
[Merge] ~petermakowski/maas-site-manager:update-fe-lint into maas-site-manager:main
From: Peter Makowski, 2023-03-01