← Back to team overview

sts-sponsors team mailing list archive

Re: [Merge] ~lloydwaltersj/maas:oapi-include-more-methods into maas:master

 


Diff comments:

> diff --git a/src/maasserver/api/volume_groups.py b/src/maasserver/api/volume_groups.py
> index 553e7c7..5c67787 100644
> --- a/src/maasserver/api/volume_groups.py
> +++ b/src/maasserver/api/volume_groups.py
> @@ -349,8 +349,6 @@ class VolumeGroupHandler(OperationsHandler):
>          containing the volume group.
>          @param (int) "{id}" [required=true] The id of the volume group.
>  
> -        @param (int) "id" [required=true] The logical volume id.

you deleted the wrong one - the id is the id of the volume group, not the logical volume id

> -
>          @success (http-status-code) "server-success" 204
>  
>          @error (http-status-code) "404" 404


-- 
https://code.launchpad.net/~lloydwaltersj/maas/+git/maas/+merge/438116
Your team MAAS Maintainers is requested to review the proposed merge of ~lloydwaltersj/maas:oapi-include-more-methods into maas:master.



References