sts-sponsors team mailing list archive

[Adam Collard <mp+437920@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/maas_release_tools/scripts/release_status.py b/maas_release_tools/scripts/release_status.py
> index b1835ce..f23c3e3 100644
> --- a/maas_release_tools/scripts/release_status.py
> +++ b/maas_release_tools/scripts/release_status.py
> @@ -230,15 +230,14 @@ class CommitInRemoteBranch(ReleaseStep):
>          return self.git.get_official_remote()
>  
>      @property
> -    @lru_cache(maxsize=1)
> -    def release_branch_name(self):
> +    def release_branch_name(self) -> str:

hmm, why did you remove the cache?

>          if self.preparer.version.grade in ("alpha", "beta"):
>              # alpha and beta releases are released from master/main
>              return self.default_branch
>          else:
>              return self.preparer.version.major
>  
> -    def check(self) -> tuple[bool, str]:
> +    def check(self) -> tuple[bool, str | None]:
>          if not self.official_remote:
>              return False, "Official remote not found"
>          remote_branches = self.git.get_remote_branches_containing("HEAD")


-- 
https://code.launchpad.net/~alexsander-souza/maas/+git/maas-release-tools/+merge/437920
Your team MAAS Committers is requested to review the proposed merge of ~alexsander-souza/maas/+git/maas-release-tools:final_version_checks into ~maas-committers/maas/+git/maas-release-tools:main.