sts-sponsors team mailing list archive

[Alexsander de Souza <mp+438281@xxxxxxxxxxxxxxxxxx>]

Review: Approve

+1, just some nits inline

Diff comments:

> diff --git a/backend/Dockerfile b/backend/Dockerfile
> new file mode 100644
> index 0000000..e2a7226
> --- /dev/null
> +++ b/backend/Dockerfile
> @@ -0,0 +1,27 @@
> +FROM python:3.10
> +LABEL maintainer="MAAS Commiters <maas-commiters@xxxxxxxxxxxxx>"
> +
> +ARG VERSION=development
> +ENV VERSION ${VERSION}
> +
> +# ensure python stdout and stderr streams are sent straight to terminal
> +# also ensure nothing is buffered and thus may never be written
> +ENV PYTHONUNBUFFERED 1
> +
> +# RUN apt-get update -q -y && apt-get install -q -y --no-install-recommends --no-install-suggests \

leftovers from tests?

> +#   tox
> +
> +RUN python -m pip install --user tox
> +
> +# create app directory
> +RUN mkdir /app

can drop this, WORKDIR creates the dir if it doesn't exist

> +WORKDIR /app
> +
> +# Bundle app source
> +COPY . /app/
> +
> +# Expose port
> +EXPOSE 8000
> +
> +#ENTRYPOINT ["tail", "-f", "/dev/null"]  # to keep it running for debugging
> +ENTRYPOINT ["python", "-m", "tox", "-e", "run", "run"]


-- 
https://code.launchpad.net/~thorsten-merten/maas-site-manager/+git/maas-site-manager/+merge/438281
Your team MAAS Committers is subscribed to branch ~thorsten-merten/maas-site-manager:MAASENG-1451-setup-docker-compose.