sts-sponsors team mailing list archive

[Peter Makowski <mp+438529@xxxxxxxxxxxxxxxxxx>]

Peter Makowski has proposed merging ~petermakowski/maas-site-manager:fix-ColumnsVisibilityControl-key into maas-site-manager:main.

Commit message:
fix(ColumnsVisibilityControl): move key to top-level node

Requested reviews:
  MAAS Lander (maas-lander): unittests
  MAAS Committers (maas-committers)

For more details, see:
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/438529
-- 
Your team MAAS Committers is requested to review the proposed merge of ~petermakowski/maas-site-manager:fix-ColumnsVisibilityControl-key into maas-site-manager:main.

diff --git a/frontend/src/components/SitesList/components/ColumnsVisibilityControl.tsx b/frontend/src/components/SitesList/components/ColumnsVisibilityControl.tsx
index c799b88..83b8178 100644
--- a/frontend/src/components/SitesList/components/ColumnsVisibilityControl.tsx
+++ b/frontend/src/components/SitesList/components/ColumnsVisibilityControl.tsx
@@ -23,10 +23,9 @@ function ColumnsVisibilityControl({ columns }: { columns: SitesColumn[] }) {
           .filter((column) => column.id !== "select")
           .map((column) => {
             return (
-              <div className="columns-visibility-checkbox">
+              <div className="columns-visibility-checkbox" key={column.id}>
                 <CheckboxInput
                   aria-label={column.id}
-                  key={column.id}
                   label={column.id}
                   {...{
                     checked: column.getIsVisible(),