sts-sponsors team mailing list archive

[Alexsander de Souza <mp+438631@xxxxxxxxxxxxxxxxxx>]

Alexsander de Souza has proposed merging ~alexsander-souza/maas/+git/maas-release-tools:fix_spell into ~maas-committers/maas/+git/maas-release-tools:main.

Commit message:
fix spell

Requested reviews:
  MAAS Committers (maas-committers)

For more details, see:
https://code.launchpad.net/~alexsander-souza/maas/+git/maas-release-tools/+merge/438631
-- 
Your team MAAS Committers is requested to review the proposed merge of ~alexsander-souza/maas/+git/maas-release-tools:fix_spell into ~maas-committers/maas/+git/maas-release-tools:main.

diff --git a/maas_release_tools/git.py b/maas_release_tools/git.py
index ef96003..6e90a1c 100644
--- a/maas_release_tools/git.py
+++ b/maas_release_tools/git.py
@@ -61,7 +61,7 @@ class Git:
                 return name
         return None
 
-    def has_uncommited_changes(self) -> bool:
+    def has_uncommitted_changes(self) -> bool:
         result = self._run("diff-index", "--quiet", "HEAD")
         return not result.succeeded
 
diff --git a/maas_release_tools/launchpad.py b/maas_release_tools/launchpad.py
index ae17631..96a753a 100644
--- a/maas_release_tools/launchpad.py
+++ b/maas_release_tools/launchpad.py
@@ -63,8 +63,8 @@ class LaunchpadActions:
         except NotFound:
             return None
 
-    def get_ppa_dependecies(self, ppa) -> list[str]:
-        """Return a list this ppa dependecies"""
+    def get_ppa_dependencies(self, ppa) -> list[str]:
+        """Return a list this ppa dependencies"""
         return [d.dependency.name for d in ppa.dependencies]
 
     def get_snap_builder(self, builder_name: str):
@@ -201,7 +201,7 @@ class LaunchpadActions:
         for bug_task in bug_tasks:
             if fixed_before and bug_task.date_fix_committed > fixed_before:
                 self.logger.debug(
-                    f"skiping bug {bug_task.bug.id}, fixed after the release date"
+                    f"skipping bug {bug_task.bug.id}, fixed after the release date"
                 )
                 continue
             self.logger.info(
diff --git a/maas_release_tools/scripts/release_status.py b/maas_release_tools/scripts/release_status.py
index 797d92d..0edf5fc 100644
--- a/maas_release_tools/scripts/release_status.py
+++ b/maas_release_tools/scripts/release_status.py
@@ -181,7 +181,7 @@ class ReleaseStep(ABC):
         method should execute the procedure.
 
         Returns a tuple of (fixed, how_to_fix), where fixed is True if the fix was
-        sucessful, and False when this failure could not be recovered. how_to_fix is
+        successful, and False when this failure could not be recovered. how_to_fix is
         an array with manual steps the user should do to fix this.
         """
         return (
@@ -204,7 +204,7 @@ class NoUncommittedChanges(ReleaseStep):
         return "No uncommitted changes"
 
     def check(self) -> tuple[bool, str | None]:
-        if self.git.has_uncommited_changes():
+        if self.git.has_uncommitted_changes():
             return False, "Your local repository is not clean"
         else:
             return True, None
@@ -480,7 +480,7 @@ class MAASPPA(ReleaseStep):
             )
 
         if self.deps is not None:
-            ppa_deps = set(self.launchpad.get_ppa_dependecies(self.ppa))
+            ppa_deps = set(self.launchpad.get_ppa_dependencies(self.ppa))
             missing_deps = sorted(set(self.deps).difference(ppa_deps))
             if missing_deps:
                 return False, (
@@ -833,7 +833,7 @@ class SnapsUploaded(ReleaseStep):
         )
 
     @lru_cache(maxsize=1)
-    def _get_revisisions(self):
+    def _get_revisions(self):
         # XXX: This considers only the last 500 uploaded revisions. That's fine
         #     if you're currently working on the release, but it will
         #     fail if you check back later. We should probably make the
@@ -864,7 +864,7 @@ class SnapsUploaded(ReleaseStep):
         ) and version.endswith(self.preparer.git_short_rev)
 
     def check(self) -> tuple[bool, str | None]:
-        revision_map, error_message = self._get_revisisions()
+        revision_map, error_message = self._get_revisions()
         if revision_map is None:
             return False, error_message
 
@@ -926,7 +926,7 @@ class SnapsInChannel(SnapsUploaded):
         return f"Snap `{self.snap_name}` has been released to {self.channel}"
 
     def check(self) -> tuple[bool, str | None]:
-        revision_map, error_message = self._get_revisisions()
+        revision_map, error_message = self._get_revisions()
         if revision_map is None:
             return False, error_message
         released_archs = set()
@@ -948,7 +948,7 @@ class SnapsInChannel(SnapsUploaded):
 
     def fix(self, doit=False):
         steps = []
-        revision_map, _ = self._get_revisisions()
+        revision_map, _ = self._get_revisions()
 
         for arch in self.missing_archs:
             if revision_map is None or len(revision_map.get(arch, [])) == 0:
@@ -1113,7 +1113,7 @@ class BugMovedToMilestone(ReleaseStep):
 
     def fix(self, doit: bool = False) -> tuple[bool, list[str]]:
         if not self._ms_found:
-            return False, ["Pre-requesites check has failed, check above"]
+            return False, ["Pre-requisites check has failed, check above"]
         return False, [
             f"run {os.path.dirname(sys.argv[0])}/release-manage maas move-done-bugs {self.preparer.version.final_version} {self.preparer.version.version}"
         ]
@@ -1148,7 +1148,7 @@ class MilestoneReleased(ReleaseStep):
 
     def fix(self, doit: bool = False) -> tuple[bool, list[str]]:
         if not self._ms_found:
-            return False, ["Pre-requesites check has failed, check above"]
+            return False, ["Pre-requisites check has failed, check above"]
         return False, [
             f"run {os.path.dirname(sys.argv[0])}/release-manage maas release-milestone {self.preparer.version.version}"
         ]