sts-sponsors team mailing list archive

[Thorsten Merten <mp+438687@xxxxxxxxxxxxxxxxxx>]

Review: Approve

I understand this as a first step and that we can transfer more deps to this image in a next step (e.g. yarnpkg).

One minor nag line.

Diff comments:

> diff --git a/Dockerfile b/Dockerfile
> index fdbc3c6..18e89d6 100644
> --- a/Dockerfile
> +++ b/Dockerfile
> @@ -22,23 +19,17 @@ RUN set -ex                                                                     
>  RUN echo ${CACHE_BUST} > /root/.cache_buster
>  
>  RUN set -ex                                                                                            ;\
> -    apt-get update                                                                                     ;\
> -    apt-get -y upgrade                                                                                 ;\
> -    apt-get -y install \
> +    apt-get -q update                                                                                  ;\

You could && those together.

> +    apt-get -q -y upgrade                                                                              ;\
> +    apt-get -q -y install \
>          git \
> -        gpg-agent \
> -        iproute2 \
> -        language-pack-en \
> -        lsb-release \
>          make \
> -        rsyslog \
> +        python3-launchpadlib \
> +        python3-yaml \
>          socat \
> -        software-properties-common \
>          sudo \
> -        systemd \
>          wget
>  
>  RUN set -ex                                                                                            ;\
> -    git clone ${GIT_REPOS} --single-branch --branch ${GIT_BRANCH} --depth 1 /work/checkout             ;\
>      make -C /work/checkout ${MAKE_TARGET}                                                              ;\
>      rm -rf /work/checkout


-- 
https://code.launchpad.net/~adam-collard/maas-ci/+git/maas-ci-internal/+merge/438687
Your team MAAS Committers is subscribed to branch ~maas-committers/maas-ci/+git/maas-ci-internal:main.