← Back to team overview

sts-sponsors team mailing list archive

Re: [Merge] ~adam-collard/maas/+git/maas-release-tools:black-format into ~maas-committers/maas/+git/maas-release-tools:main

 


Diff comments:

> diff --git a/Makefile b/Makefile
> index cb3ca9a..ebaed92 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -19,7 +18,8 @@ clean:
>  	rm -rf $(TOX_DIR) $(BIN_DIR) *.egg-info
>  .PHONY: clean
>  
> -deps: $(TOX) $(SHELLCHECK)
> +deps: $(TOX)
> +	sudo apt install shellcheck

I would also drop the $(TOX) var and target and install tox too here

>  .PHONY: deps
>  
>  bins: py-bins shell-bins


-- 
https://code.launchpad.net/~adam-collard/maas/+git/maas-release-tools/+merge/438959
Your team MAAS Committers is subscribed to branch ~maas-committers/maas/+git/maas-release-tools:main.



References