← Back to team overview

sts-sponsors team mailing list archive

[Merge] ~adam-collard/maas/+git/maas-release-tools:mypy-fixes into ~maas-committers/maas/+git/maas-release-tools:main

 

Adam Collard has proposed merging ~adam-collard/maas/+git/maas-release-tools:mypy-fixes into ~maas-committers/maas/+git/maas-release-tools:main.

Commit message:
Fix mypy


Requested reviews:
  MAAS Committers (maas-committers)

For more details, see:
https://code.launchpad.net/~adam-collard/maas/+git/maas-release-tools/+merge/438970
-- 
Your team MAAS Committers is requested to review the proposed merge of ~adam-collard/maas/+git/maas-release-tools:mypy-fixes into ~maas-committers/maas/+git/maas-release-tools:main.
diff --git a/.launchpad.yaml b/.launchpad.yaml
index b71ea93..6ab1b6b 100644
--- a/.launchpad.yaml
+++ b/.launchpad.yaml
@@ -6,5 +6,10 @@ jobs:
   lint:
     series: jammy
     architectures: amd64
+<<<<<<< .launchpad.yaml
     packages: [git, tox]
     run: tox -e lint
+=======
+    packages: [make]
+    run: make deps lint
+>>>>>>> .launchpad.yaml
diff --git a/maas_release_tools/scripts/release_status.py b/maas_release_tools/scripts/release_status.py
index 0edf5fc..6db3367 100644
--- a/maas_release_tools/scripts/release_status.py
+++ b/maas_release_tools/scripts/release_status.py
@@ -1240,7 +1240,7 @@ class UsnBuilderUpdated(ReleaseStep):
 class LaunchpadSeriesUpdated(ReleaseStep):
     def __init__(self, preparer: ReleasePreparer, cwd: str | None = None):
         super().__init__(preparer, cwd)
-        self._series = None
+        self._series: str | None = None
 
     @property
     def title(self) -> str:
@@ -1250,8 +1250,7 @@ class LaunchpadSeriesUpdated(ReleaseStep):
         return self.preparer.version.grade != "final"
 
     def check(self) -> tuple[bool, str | None]:
-        self._series = self.launchpad.get_series_status()
-        for n, (name, status) in enumerate(self._series):
+        for n, (name, status) in enumerate(self.launchpad.get_series_status()):
             match n:
                 case 0:
                     if status != "Active Development":

Follow ups