sts-sponsors team mailing list archive

[Alberto Donato <mp+438934@xxxxxxxxxxxxxxxxxx>]

Review: Approve

+1, nice

one nit inline

Diff comments:

> diff --git a/maas_release_tools/scripts/release_status.py b/maas_release_tools/scripts/release_status.py
> index 6db3367..476e5a2 100644
> --- a/maas_release_tools/scripts/release_status.py
> +++ b/maas_release_tools/scripts/release_status.py
> @@ -1317,12 +1348,24 @@ def parse_args():
>          help="Don't execute actions",
>      )
>      parser.add_argument(
> +        "--sol-qa-approval",
> +        action="store_true",
> +        dest="sol_qa_approval",

it shouldn't be necessary to pass `dest` here and below, they are derived automatically

> +        help="SolQA has given the thumbs up",
> +    )
> +    parser.add_argument(
>          "--launchpad-credentials",
>          default=None,
>          type=FileType(),
>          help="Launchpad credentials file",
>      )
>      parser.add_argument(
> +        "--jenkins-skip",
> +        action="store_true",
> +        dest="jenkins_skip",
> +        help="Skip System Integration Tests checks",
> +    )
> +    parser.add_argument(
>          "--jenkins-config",
>          default=JJB_CONFIG,
>          type=FileType(),


-- 
https://code.launchpad.net/~alexsander-souza/maas/+git/maas-release-tools/+merge/438934
Your team MAAS Committers is subscribed to branch ~maas-committers/maas/+git/maas-release-tools:main.