sts-sponsors team mailing list archive

[Adam Collard <mp+438971@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/maas_release_tools/scripts/__init__.py b/maas_release_tools/scripts/__init__.py
> index f6db5a9..011a57d 100644
> --- a/maas_release_tools/scripts/__init__.py
> +++ b/maas_release_tools/scripts/__init__.py
> @@ -31,3 +11,9 @@ def convert_file_descriptors_to_path(ns: Namespace):
>          if isinstance(value, IO):
>              value.close()
>              setattr(ns, "name", Path(value.name))
> +
> +
> +def get_all_script_names() -> List[str]:

any reason get_all_script_names can't move directly to __main__.py and not __init__.py so that we avoid imports for all imports of scripts?

> +    """Return names of all scripts for the package."""
> +    dist = get_distribution("maas-release-tools")
> +    return sorted(dist.get_entry_map("console_scripts"))


-- 
https://code.launchpad.net/~ack/maas/+git/maas-release-tools/+merge/438971
Your team MAAS Committers is subscribed to branch ~maas-committers/maas/+git/maas-release-tools:main.