sts-sponsors team mailing list archive

[Jones Ogolo <mp+439146@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing

Everything looks good, just a minor alignment issue

Diff comments:

> diff --git a/frontend/src/components/TokensList/TokensList.tsx b/frontend/src/components/TokensList/TokensList.tsx
> index 4125a07..a366f95 100644
> --- a/frontend/src/components/TokensList/TokensList.tsx
> +++ b/frontend/src/components/TokensList/TokensList.tsx
> @@ -3,25 +3,25 @@ import { Outlet, Link } from "react-router-dom";
>  
>  const TokensList = () => {
>    return (
> -    <section>
> -      <Row>
> -        <Col size={2}>
> -          <h2 className="p-heading--4">Tokens</h2>
> -        </Col>
> -      </Row>
> -      <Row>
> -        <Col size={12}>
> -          <Button>Export</Button>
> -          <Button appearance="negative">Delete</Button>
> -          <Link to="create">
> -            <Button appearance="positive" element="a">
> +    <>
> +      <section>
> +        <Row>
> +          <Col size={2}>
> +            <h2 className="p-heading--4">Tokens</h2>
> +          </Col>
> +        </Row>
> +        <Row>
> +          <Col size={12}>

I think from the spec, this button group should have an alignment to the right of the screen.

> +            <Button>Export</Button>
> +            <Button appearance="negative">Delete</Button>
> +            <Link className="p-button--positive" role="button" state={{ sidebar: true }} to="">
>                Generate tokens
> -            </Button>
> -          </Link>
> -        </Col>
> -      </Row>
> +            </Link>
> +          </Col>
> +        </Row>
> +      </section>
>        <Outlet />
> -    </section>
> +    </>
>    );
>  };
>  


-- 
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/439146
Your team MAAS Committers is subscribed to branch ~petermakowski/maas-site-manager:add-side-panel-MAASENG-1487.