sts-sponsors team mailing list archive

[Adam Collard <mp+439218@xxxxxxxxxxxxxxxxxx>]

Review: Needs Fixing



Diff comments:

> diff --git a/src/maascli/snap.py b/src/maascli/snap.py
> index a8b8068..58a6747 100644
> --- a/src/maascli/snap.py
> +++ b/src/maascli/snap.py
> @@ -568,6 +567,8 @@ def get_vault_settings(options) -> dict:
>      if not options.vault_uri:
>          return {}
>  
> +    from maasserver.vault import prepare_wrapped_approle, VaultError

this doesn't look right - why would we have the server code available to the CLI?

> +
>      required_arguments = [
>          "vault-approle-id",
>          "vault-wrapped-token",


-- 
https://code.launchpad.net/~troyanov/maas/+git/maas/+merge/439218
Your team MAAS Committers is subscribed to branch maas:master.