sts-sponsors team mailing list archive

[Alberto Donato <mp+439621@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/src/maasserver/tests/test_bootresources.py b/src/maasserver/tests/test_bootresources.py
> index 92ad426..ad2814b 100644
> --- a/src/maasserver/tests/test_bootresources.py
> +++ b/src/maasserver/tests/test_bootresources.py
> @@ -1717,7 +1718,7 @@ class TestImportImages(MAASTransactionServerTestCase):
>              sources=[], product_mapping=product_mapping, store=store
>          )
>          self.assertThat(
> -            listener.register, MockCalledOnceWith("sys_stop_import", ANY)
> +            listener.listen, MockCalledOnceWith("sys_stop_import", ANY)
>          )

since you're changing this, please switch it to

  listener.listen_assert_called_once_with(...)

 (one less assertThat)

Same for other added tests below

>  
>      def test_download_all_boot_resources_calls_cancel_finalize(self):


-- 
https://code.launchpad.net/~igor-brovtsin/maas/+git/maas/+merge/439621
Your team MAAS Maintainers is requested to review the proposed merge of ~igor-brovtsin/maas:lp-1743648 into maas:master.