sts-sponsors team mailing list archive

[Anton Troyanov <mp+440233@xxxxxxxxxxxxxxxxxx>]

Review: Approve

I am wondering if we need to handle SENSITIVE_VALUE_PLACEHOLDER when params are being set? So we don't overwrite data in the database with that one.

Otherwise +1 

Diff comments:

> diff --git a/src/maasserver/models/tests/test_bmc.py b/src/maasserver/models/tests/test_bmc.py
> index b766810..86b05ca 100644
> --- a/src/maasserver/models/tests/test_bmc.py
> +++ b/src/maasserver/models/tests/test_bmc.py
> @@ -646,6 +649,17 @@ class TestBMC(MAASServerTestCase):
>  
>          self.assertEqual({"foo": "bar"}, bmc.get_power_parameters())
>  
> +    def test_get_power_params_masks_sensitiver(self):

sensitiver?

> +        bmc = factory.make_BMC(power_type="ipmi")
> +        secret_manager = SecretManager()
> +        secret_manager.set_composite_secret(
> +            "power-parameters", {"power_pass": "bar"}, obj=bmc
> +        )
> +        self.assertEqual(
> +            {"power_pass": SENSITIVE_VALUE_PLACEHOLDER},
> +            bmc.get_power_parameters(mask_sensitive=True),
> +        )
> +
>  
>  class TestPodManager(MAASServerTestCase):
>      def enable_rbac(self):


-- 
https://code.launchpad.net/~igor-brovtsin/maas/+git/maas/+merge/440233
Your team MAAS Committers is subscribed to branch maas:master.