sts-sponsors team mailing list archive

[Peter Makowski <mp+440316@xxxxxxxxxxxxxxxxxx>]

Diff comments:

> diff --git a/Makefile b/Makefile
> index 8976954..e73f7f8 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -78,7 +78,7 @@ ci-frontend-lint:
>  .PHONY: ci-frontend-lint
>  
>  ci-frontend-test:
> -	env -C frontend VITEST_JUNIT_SUITE_NAME='maas-site-manager frontend tests' yarnpkg run test --silent --reporter=junit --reporter=default --outputFile.junit=../junit-frontend.xml run
> +	env -C frontend VITEST_JUNIT_SUITE_NAME='maas-site-manager frontend tests' yarnpkg run coverage --silent --reporter=junit --reporter=default --outputFile.junit=../junit-frontend.xml run

It does, one of the tests actually failed on CI for some reason.

>  .PHONY: ci-test
>  
>  ci-e2e-test:
> diff --git a/frontend/src/main.tsx b/frontend/src/main.tsx
> index 4d3cd70..785c02c 100644
> --- a/frontend/src/main.tsx
> +++ b/frontend/src/main.tsx
> @@ -5,6 +5,7 @@ import * as ReactDOM from "react-dom/client";
>  import App from "./App";
>  import { isDev } from "./constants";
>  
> +/* c8 ignore next 4 */

This is to ignore the next 4 lines from calculating the test coverage. This doesn't need to be covered by integration tests as it's running the mock service worker in a real browser in development (which is tested via playwright).

>  if (isDev) {
>    const { worker } = await import("./mocks/browser");
>    await worker.start();


-- 
https://code.launchpad.net/~petermakowski/maas-site-manager/+git/site-manager/+merge/440316
Your team MAAS Committers is requested to review the proposed merge of ~petermakowski/maas-site-manager:add-test-coverage-ci into maas-site-manager:main.